Add tests for nvlist_clone
ClosedPublic
Actions

Authored by rstone on Feb 17 2015, 5:43 PM.

Tags

None

Referenced Files

	F105778394: D1870.diff
	Fri, Dec 20, 1:48 PM

	Unknown Object (File)
	Sun, Dec 8, 5:53 PM

	Unknown Object (File)
	Sat, Dec 7, 8:31 PM

	Unknown Object (File)
	Wed, Dec 4, 7:57 AM

	Unknown Object (File)
	Wed, Dec 4, 7:57 AM

	Unknown Object (File)
	Tue, Dec 3, 11:47 AM

	Unknown Object (File)
	Tue, Dec 3, 11:47 AM

	Unknown Object (File)
	Tue, Dec 3, 11:47 AM

View All Files

Subscribers

freebsd-net-list

pjd

Details

Reviewers

jfv

Commits

rS279425: Add tests for nvlist_clone

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rstone updated this revision to Diff 3813.Feb 17 2015, 5:43 PM

rstone retitled this revision from to Add tests for nvlist_clone.

rstone edited the test plan for this revision. (Show Details)

rstone added a reviewer: jfv.

rstone added subscribers: pjd, Unknown Object (MLST).

jfv accepted this revision.Feb 18 2015, 10:12 PM

jfv edited edge metadata.

This revision is now accepted and ready to land.Feb 18 2015, 10:12 PM

pjd added inline comments.Feb 19 2015, 7:41 AM

lib/libnv/tests/nv_tests.cc
324–331 ↗	(On Diff #3813)	Don't you want to test the clone here? If the values wre properly copied, if there is only one element, etc.? Now you are testing the source nvlist.

Fix the test case to actually test the clone

This revision now requires review to proceed.Feb 20 2015, 1:28 AM

Closed by commit rS279425 (authored by @rstone).

Revision Contents
Changeset List

Path

Size

head/

lib/

libnv/

tests/

nv_tests.cc

120 lines

Diff 4038

View Options

head/lib/libnv/tests/nv_tests.cc

Add tests for nvlist_cloneClosedPublicActions