Page MenuHomeFreeBSD
Differential D18632

Upate multimedia/kmplayer to use kf5
ClosedPublic
Actions

Authored by tcberner on Dec 22 2018, 8:52 PM.
Tags
None
Referenced Files
F81676894: D18632.id52426.diff
Fri, Apr 19, 7:11 PM
F81676877: D18632.id.diff
Fri, Apr 19, 7:11 PM
F81676687: D18632.id52248.diff
Fri, Apr 19, 7:06 PM
Unknown Object (File)
Wed, Apr 17, 9:02 AM
Unknown Object (File)
Thu, Mar 28, 2:09 PM
Unknown Object (File)
Feb 4 2024, 3:47 AM
Unknown Object (File)
Jan 29 2024, 6:06 PM
Unknown Object (File)
Jan 29 2024, 6:06 PM
View All 29 Files
Subscribers
adridg
mat

Details

Reviewers
jhale
Group Reviewers
kde
Commits
rP488708: multimedia/kmplayer: moved from multimedia/kmplayer-kde4 and updated to KF5…
Summary

Qt4 dies in 14 days.

https://github.com/freebsd/freebsd-ports-kde/commit/7456fc91c3dffc04e761d7fa92dc4c7e06aa2a85

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner created this revision.Dec 22 2018, 8:52 PM
Herald added a subscriber: mat. · View Herald TranscriptDec 22 2018, 8:52 PM
Harbormaster completed remote builds in B21685: Diff 52248.Dec 22 2018, 8:52 PM
linimon retitled this revision from Upate kmplayer to use kf5 to Upate multimedia/kmplayer to use kf5.Dec 23 2018, 7:37 AM
mat added inline comments.Dec 24 2018, 11:39 AM
multimedia/kmplayer/Makefile
5 ↗(On Diff #52248)

There is a 0.12.0 tag available, why use a beta version?

adridg added a subscriber: adridg.Dec 24 2018, 12:14 PM
adridg added inline comments.
multimedia/kmplayer/Makefile
5 ↗(On Diff #52248)

kpmplayer upstream git has the 0.12.0 tag on master 2016-06-02 and the 0.12.0b tag on master 2016-09-24 (with commit message "bump version to 0.12.0b"). In this case it's not a beta -- or rather, 0.12.0 was not a final release.

This should probably be PORTVERSION then, with some trickery.

mat added inline comments.Dec 24 2018, 1:20 PM
multimedia/kmplayer/Makefile
5 ↗(On Diff #52248)

Then it should be PORTVERSION, yes. Without any trickery.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 30 2018, 11:45 AM
Closed by commit rP488708: multimedia/kmplayer: moved from multimedia/kmplayer-kde4 and updated to KF5… (authored by tcberner). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
2 lines
multimedia/
2 lines
kmplayer-kde4/
42 lines
3 lines
3 lines
28 lines
kmplayer/
46 lines
3 lines
files/
24 lines
42 lines
34 lines
11 lines
3 lines
28 lines

Diff 52426

View Options

head/MOVED

Loading...
View Options

head/multimedia/Makefile

Loading...
View Options

head/multimedia/kmplayer-kde4/Makefile

Loading...
View Options

head/multimedia/kmplayer-kde4/distinfo

Loading...
View Options

head/multimedia/kmplayer-kde4/pkg-descr

Loading...
View Options

head/multimedia/kmplayer-kde4/pkg-plist

Loading...
View Options

head/multimedia/kmplayer/Makefile

Loading...
View Options

head/multimedia/kmplayer/distinfo

Loading...
View Options

head/multimedia/kmplayer/files/patch-git_2126d7

Loading...
View Options

head/multimedia/kmplayer/files/patch-git_3def65

Loading...
View Options

head/multimedia/kmplayer/files/patch-git_7dafda

Loading...
View Options

head/multimedia/kmplayer/files/patch-src_viewarea.cpp

Loading...
View Options

head/multimedia/kmplayer/pkg-descr

Loading...
View Options

head/multimedia/kmplayer/pkg-plist

Loading...