Page MenuHomeFreeBSD
Differential D18577

ixgbe: this statement may fall through warnings with gcc
ClosedPublic
Actions

Authored by tsoome on Dec 16 2018, 9:58 AM.
Tags
None
Referenced Files
F171580971: D18577.id52075.diff
Fri, Sep 11, 9:39 PM
F171579095: D18577.id53031.diff
Fri, Sep 11, 9:19 PM
Unknown Object (File)
Aug 12 2026, 12:51 PM
Unknown Object (File)
Aug 12 2026, 12:04 PM
Unknown Object (File)
Aug 10 2026, 12:13 PM
Unknown Object (File)
Aug 5 2026, 5:22 AM
Unknown Object (File)
Aug 4 2026, 5:23 AM
Unknown Object (File)
Jul 27 2026, 3:10 PM
View All Files
Subscribers
ae
imp

Details

Reviewers
sbruno
Commits
rS344094: MFC: r343203
rS344095: MFC: r343203
rS343203: ixgbe: this statement may fall through warnings with gcc
Summary

The recent gcc versions (7 and 8 at least) can check for switch case
statements for fall through (implicit-fallthrough). When fall through
is intentional, the default method for warning suppression is to place
comment /* FALLTHROUGH */ exactly before next case statement.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tsoome created this revision.Dec 16 2018, 9:58 AM
Herald added a reviewer: sbruno. · View Herald TranscriptDec 16 2018, 9:58 AM
Herald added subscribers: ae, imp. · View Herald Transcript
Harbormaster completed remote builds in B21597: Diff 52075.Dec 16 2018, 9:58 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2019, 8:45 PM
Closed by commit rS343203: ixgbe: this statement may fall through warnings with gcc (authored by tsoome). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ixgbe/
4 lines
6 lines

Diff 53031

View Options

head/sys/dev/ixgbe/ixgbe_82599.c

Loading...
View Options

head/sys/dev/ixgbe/ixgbe_common.c

Loading...