Fix alligment issue in uefisign.
ClosedPublic
Actions

Authored by kd on Dec 14 2018, 2:34 PM.

Tags

None

Referenced Files

	F81664457: D18554.diff
	Fri, Apr 19, 4:05 PM

	Unknown Object (File)
	Wed, Apr 17, 7:27 AM

	Unknown Object (File)
	Thu, Mar 28, 4:42 PM

	Unknown Object (File)
	Mar 8 2024, 6:39 AM

	Unknown Object (File)
	Mar 8 2024, 6:32 AM

	Unknown Object (File)
	Mar 8 2024, 6:32 AM

	Unknown Object (File)
	Mar 8 2024, 6:19 AM

	Unknown Object (File)
	Dec 20 2023, 3:17 AM

View All 20 Files

Subscribers

imp

Details

Reviewers

mw
mst_semihalf.com
trasz

Commits

rS342253: Fix alignment issue in uefisign

Summary

The pe_certificate structure has to be aligned to 8 bytes(source)
Since this is now checked in edk2, any binaries signed with older version of this tool will fail verification.

Test Plan

Test it using qemu with OVMF as firmware.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kd created this revision.Dec 14 2018, 2:34 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 14 2018, 2:34 PM

Assuming you've tested it and it it's good, then it's good, thank you :-)

This revision is now accepted and ready to land.Dec 17 2018, 3:56 PM

Closed by commit rS342253: Fix alignment issue in uefisign (authored by mw). · Explain WhyDec 19 2018, 10:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

uefisign/

pe.c

22 lines

Diff 52175

View Options

head/usr.sbin/uefisign/pe.c

Fix alligment issue in uefisign.ClosedPublicActions