Differential D18542

dtrace: fix userspace access on boxes with SMAP
ClosedPublic
Actions

Authored by mjg on Dec 13 2018, 7:31 PM.

Project Tags

None

Referenced Files

None

Subscribers

imp

Details

Reviewers

markj
gnn

Commits

rS342053: dtrace: fix userspace access on boxes with SMAP

Summary

This in particular fixes ustack().

illumos also has SMAP support and patched the same routines, but with adding func calls inside. The files already diverged regardless of this so I think we should go for ifunc (as in this patch).

Test Plan

dtrace -n 'pid$target:::entry { @[ustack()] = count(); }' -c /bin/sh

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.Dec 13 2018, 7:31 PM

Herald added a reviewer: gnn. · View Herald TranscriptDec 13 2018, 7:31 PM

Herald added a subscriber: imp. · View Herald Transcript

mjg edited the summary of this revision. (Show Details)Dec 13 2018, 7:31 PM

Harbormaster completed remote builds in B21542: Diff 51967.Dec 13 2018, 7:33 PM

Thanks. Do you plan to MFC this?

sys/cddl/dev/dtrace/amd64/dtrace_asm.S
357 ↗	(On Diff #51967)	The order of stac/clac is inverted here.

Yea, 1 week.

too bad i did not find this before 12.0, i guess it can get in as an EN.

sys/cddl/dev/dtrace/amd64/dtrace_asm.S
357 ↗	(On Diff #51967)	ops, thanks

This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2018, 8:12 PM

Closed by commit rS342053: dtrace: fix userspace access on boxes with SMAP. · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

cddl/

dev/

dtrace/

amd64/

dtrace_asm.S

107 lines

dtrace_isa.c

68 lines

Diff 51972

View Options

head/sys/cddl/dev/dtrace/amd64/dtrace_asm.S