USES=cargo to respect CC for linking
ClosedPublic
Actions

Authored by jbeich on Dec 12 2018, 4:07 PM.

Details

Reviewers

None

Group Reviewers

rust
O5: Ports Framework	(Owns No Changed Paths)
portmgr

Commits

rP487455: USES=cargo to respect CC for linking

Summary

No consumers change CC atm but if users do something like CC=ccache gcc9 build will fail as -C linker appears to only accept command (found via PATH) or absolute path.

Test Plan

devel/rust-bindgen

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 21516
Build 20829: arc lint + arc unit

Event Timeline

jbeich created this revision.Dec 12 2018, 4:07 PM

Harbormaster completed remote builds in B21515: Diff 51911.Dec 12 2018, 4:09 PM

jbeich set the repository for this revision to rP FreeBSD ports repository.Dec 12 2018, 4:10 PM

Herald added a reviewer: portmgr. · View Herald TranscriptDec 12 2018, 4:10 PM

Oops, drop repository type. We don't need portmgr in this review. ;)

Harbormaster completed remote builds in B21516: Diff 51912.Dec 12 2018, 4:12 PM

Hmm, I guess it's ok.

Do you have any example use cases in mind for overriding the linker driver?

I build base and ports using devel/llvm60 and /usr/bin/cc doesn't exist. The binary rust package seems to have /usr/bin/cc hardcoded and can't build any rust ports without this change. (Firefox does build, but that's because its build scripts add -C linker.)

tobik accepted this revision as: rust.Dec 13 2018, 10:23 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2018, 6:20 PM

Closed by commit rP487455: USES=cargo to respect CC for linking (authored by jbeich). · Explain Why

This revision was automatically updated to reflect the committed changes.

Owners added a reviewer: O5: Ports Framework.Dec 14 2018, 6:20 PM

Herald added a reviewer: portmgr. · View Herald TranscriptDec 14 2018, 6:20 PM