Page MenuHomeFreeBSD

Free bootstacks after AP startup.
ClosedPublic

Authored by kib on Dec 8 2018, 11:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 7, 3:37 AM
Unknown Object (File)
Sat, Jul 4, 7:48 AM
Unknown Object (File)
Sat, Jul 4, 3:03 AM
Unknown Object (File)
Fri, Jul 3, 5:37 AM
Unknown Object (File)
Wed, Jul 1, 1:49 AM
Unknown Object (File)
May 10 2026, 8:48 PM
Unknown Object (File)
May 7 2026, 9:38 PM
Unknown Object (File)
May 7 2026, 5:32 PM
Subscribers

Details

Summary

Bootstacks are unused after APs executed sched_throw() in init_secondary_tail() and started executing on proper idle thread stack.
Add sysinit that detects that the idle thread for each CPU was scheduled at least once, and free corresponding bootstack.

I believe that slight addition of the code (~200 bytes) is worth it, because even on typical small modern desktop CPU we leak 128K of memory otherwise (4 pages x 8 threads).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I also think it is worth it.

This revision is now accepted and ready to land.Dec 10 2018, 7:01 PM
This revision was automatically updated to reflect the committed changes.