Page MenuHomeFreeBSD

Free bootstacks after AP startup.
ClosedPublic

Authored by kib on Dec 8 2018, 11:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 23, 12:00 AM
Unknown Object (File)
Sat, Aug 22, 8:51 AM
Unknown Object (File)
Sat, Aug 22, 8:46 AM
Unknown Object (File)
Mon, Aug 17, 7:34 AM
Unknown Object (File)
Thu, Aug 13, 5:56 PM
Unknown Object (File)
Wed, Aug 12, 4:31 PM
Unknown Object (File)
Tue, Aug 11, 6:46 PM
Unknown Object (File)
Mon, Aug 10, 3:38 PM
Subscribers

Details

Summary

Bootstacks are unused after APs executed sched_throw() in init_secondary_tail() and started executing on proper idle thread stack.
Add sysinit that detects that the idle thread for each CPU was scheduled at least once, and free corresponding bootstack.

I believe that slight addition of the code (~200 bytes) is worth it, because even on typical small modern desktop CPU we leak 128K of memory otherwise (4 pages x 8 threads).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I also think it is worth it.

This revision is now accepted and ready to land.Dec 10 2018, 7:01 PM
This revision was automatically updated to reflect the committed changes.