Page MenuHomeFreeBSD

Allow to create swap zone larger than v_page_count / 2.
ClosedPublic

Authored by kib on Thu, Nov 29, 6:36 PM.

Details

Summary

If user configured maxswapzone tunable, just take the literal value for the initial zone sizing attempt. Before, it was only possible to reduce the zone by a tunable.

Reported by: jmg

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib created this revision.Thu, Nov 29, 6:36 PM
markj accepted this revision.Thu, Nov 29, 9:40 PM
markj added inline comments.
sys/vm/swap_pager.c
550 ↗(On Diff #51363)

Perhaps, "taking the user's requested size or estimating the number we need..."?

583 ↗(On Diff #51363)

Did you make this change because uma_zone_reserve_kva() can round up?

This revision is now accepted and ready to land.Thu, Nov 29, 9:40 PM
kib updated this revision to Diff 51370.Thu, Nov 29, 10:38 PM

Comment rewording.

This revision now requires review to proceed.Thu, Nov 29, 10:38 PM
kib marked an inline comment as done.Thu, Nov 29, 10:39 PM
kib added inline comments.
sys/vm/swap_pager.c
583 ↗(On Diff #51363)

Yes, somebody noted it to me long time ago, but I did not considered it worth fixing alone.

markj accepted this revision.Thu, Nov 29, 10:44 PM
This revision is now accepted and ready to land.Thu, Nov 29, 10:44 PM
This revision was automatically updated to reflect the committed changes.