Upstream recently tagged v0.4 which includes some important bug fixes. Update our port to the new version sourced from the public Bitbucket repo, and make myself maintainer while I'm here.
Details
Details
- Reviewers
- None
- Group Reviewers
Ports Committers - Commits
- rP493891: Assume maintainership of benchmarks/spp and update to v0.4 which addresses:
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Please use devel/arcanist, or generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.
| benchmarks/spp/Makefile | ||
|---|---|---|
| 8 ↗ | (On Diff #51102) | It makes no sense to set DISTVERSION while also setting PORTVERSION. See 5.2.2. Versions, DISTVERSION or PORTVERSION. |
| 12 ↗ | (On Diff #51102) | Wrong place in the Makefile. See 15. Order of Variables in Port Makefiles. |
Comment Actions
Full context diff, shuffle variable order and ditch DISTVERSION in favour of a custom variable to hold the commit hash used in the tarball directory name.
| benchmarks/spp/pkg-descr | ||
|---|---|---|
| 8–9 ↗ | (On Diff #51106) | Only 1 WWW line. |
Comment Actions
Checked with one of the authors. Preference is to reference the Bitbucket URL in pkg-descr if it can only list a single URL.
Comment Actions
Thanks all for the feedback... I'm a bit rusty on working with ports. Will commit sometime this week with my src commit bit hat on and "review/approved by:" if no further feedback materialises.