Page MenuHomeFreeBSD

sfxge(4): use simpler code to check hash algorithm type
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 6, 11:28 PM
Unknown Object (File)
Fri, Oct 31, 1:03 AM
Unknown Object (File)
Sun, Oct 26, 7:22 AM
Unknown Object (File)
Sun, Oct 26, 7:22 AM
Unknown Object (File)
Sun, Oct 26, 7:22 AM
Unknown Object (File)
Sun, Oct 26, 12:39 AM
Unknown Object (File)
Sat, Oct 25, 5:01 PM
Unknown Object (File)
Sat, Oct 25, 6:52 AM
Subscribers

Details

Summary

The API which is used to list supported hash flags verifies
hash algorithm choice before writing the output. This check
is based on a switch() statement which has only two options
and no distinctive actions to be conducted for each of them.
Use simpler code instead of switch() to improve readability.

Submitted by: Ivan Malov <ivan.malov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM
This revision was automatically updated to reflect the committed changes.