Differential D18266

sfxge(4): use simpler code to check hash algorithm type
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 18, 3:33 PM

	Unknown Object (File)
	Fri, Sep 18, 3:26 PM

	Unknown Object (File)
	Fri, Sep 18, 3:23 PM

	Unknown Object (File)
	Sat, Sep 5, 4:03 AM

	Unknown Object (File)
	Fri, Sep 4, 1:20 PM

	Unknown Object (File)
	Sun, Aug 30, 6:06 AM

	Unknown Object (File)
	Sat, Aug 29, 1:02 AM

	Unknown Object (File)
	Aug 20 2026, 11:29 PM

Subscribers

Details

Reviewers

gnn
philip

Commits

rS341304: sfxge(4): use simpler code to check hash algorithm type

Summary

The API which is used to list supported hash flags verifies
hash algorithm choice before writing the output. This check
is based on a switch() statement which has only two options
and no distinctive actions to be conducted for each of them.
Use simpler code instead of switch() to improve readability.

Submitted by: Ivan Malov <ivan.malov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:56 AM

Harbormaster completed remote builds in B21124: Diff 50865.Nov 21 2018, 11:56 AM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM

Closed by commit rS341304: sfxge(4): use simpler code to check hash algorithm type (authored by arybchik). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:07 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

sfxge/

common/

39 lines

Diff 51399

head/sys/dev/sfxge/common/efx_rx.c

Loading...