Page MenuHomeFreeBSD
Differential D18240

sfxge(4): get max supported value for action MARK
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 11:11 PM
Unknown Object (File)
Mon, Jan 6, 6:09 PM
Unknown Object (File)
Nov 20 2024, 10:24 PM
Unknown Object (File)
Oct 19 2024, 3:51 AM
Unknown Object (File)
Sep 30 2024, 4:49 AM
Unknown Object (File)
Sep 30 2024, 12:33 AM
Unknown Object (File)
Sep 27 2024, 12:35 PM
Unknown Object (File)
Sep 26 2024, 12:03 PM
View All 30 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341209: sfxge(4): get max supported value for action MARK
Summary

The mark value for MATCH_ACTION_MARK has a maximum value.
Requesting a value larger than the maximum will cause the
filter insertion to fail with EINVAL. This patch allows the
driver to check the value at the filter validation.

Submitted by: Roman Zhukov <roman.zhukov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21098
Build 20461: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:50 AM
Harbormaster completed remote builds in B21098: Diff 50839.Nov 21 2018, 11:50 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2018, 6:46 AM
Closed by commit rS341209: sfxge(4): get max supported value for action MARK (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2018, 6:46 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
11 lines
1 line
1 line

Diff 50839

View Options

sys/dev/sfxge/common/ef10_nic.c

Loading...
View Options

sys/dev/sfxge/common/efx.h

Loading...
View Options

sys/dev/sfxge/common/siena_nic.c

Loading...