Page MenuHomeFreeBSD
Differential D18240

sfxge(4): get max supported value for action MARK
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:50 AM.
Tags
None
Referenced Files
F149979853: D18240.id.diff
Sat, Mar 28, 1:19 PM
Unknown Object (File)
Thu, Mar 26, 9:30 PM
Unknown Object (File)
Thu, Mar 26, 11:21 AM
Unknown Object (File)
Mon, Mar 9, 1:05 AM
Unknown Object (File)
Mon, Mar 9, 1:05 AM
Unknown Object (File)
Sun, Mar 8, 6:47 PM
Unknown Object (File)
Feb 8 2026, 1:05 AM
Unknown Object (File)
Feb 7 2026, 9:44 PM
View All 80 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341209: sfxge(4): get max supported value for action MARK
Summary

The mark value for MATCH_ACTION_MARK has a maximum value.
Requesting a value larger than the maximum will cause the
filter insertion to fail with EINVAL. This patch allows the
driver to check the value at the filter validation.

Submitted by: Roman Zhukov <roman.zhukov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:50 AM
Harbormaster completed remote builds in B21098: Diff 50839.Nov 21 2018, 11:50 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2018, 6:46 AM
Closed by commit rS341209: sfxge(4): get max supported value for action MARK (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2018, 6:46 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
11 lines
1 line
1 line

Diff 51337

View Options

head/sys/dev/sfxge/common/ef10_nic.c

Loading...
View Options

head/sys/dev/sfxge/common/efx.h

Loading...
View Options

head/sys/dev/sfxge/common/siena_nic.c

Loading...