games/wesnoth: update to 1.12.1 and misc fixes
ClosedPublic
Actions

Authored by jbeich on Feb 11 2015, 3:46 PM.

Details

Reviewers

bapt
flo

Summary

Update to 1.12.1 [1]
Convert to option helpers
Stagify NLS option
Drop unsupported POOLALLOC and PYTHON options
Rename TESTS to TEST
Track direct usage of vorbisfile and fontconfig
Append / (slash) in MASTER_SITES
Don't redefine default WRKSRC

Changes: http://forums.wesnoth.org/viewtopic.php?t=41544
PR: 197478 [1]
PR: 197496
Submitted by: Torsten Zühlsdorff (maintainer) [1]
nReviewed by: ??? (mentor)
Approved by: Torsten Zühlsdorff (maintainer)
Approved by: ??? (mentor)

Not sure if maintainer would actually review (style including) my changes or just approves based on testing.

_ON and _OFF rely on default value not changing. Probably affects only ANA when it leaves WIP status.

Test Plan

poudriere testport logs are attached to bug 197496.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

jbeich updated this revision to Diff 3733.Feb 11 2015, 3:46 PM

jbeich retitled this revision from to games/wesnoth: update to 1.12.1 and misc fixes.

jbeich updated this object.

jbeich edited the test plan for this revision. (Show Details)

jbeich added reviewers: bapt, flo.

This looks good to me, maybe we can go a bit further on the @unexec rmdir converting into @dir but that would mean we do not send the message to the user.

Leave a chance to the maintainer to review/approve you latest changes (I can see on the PR/197496 that he hasn't yet)

This revision is now accepted and ready to land.Feb 11 2015, 5:38 PM

Closed by commit rP379131 (authored by @jbeich).