Page MenuHomeFreeBSD

sfxge(4): improve robustness of MAC stats get via MCDI
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 28, 8:07 PM
Unknown Object (File)
Sat, Aug 22, 8:18 PM
Unknown Object (File)
Sat, Aug 22, 5:55 PM
Unknown Object (File)
Sat, Aug 22, 8:25 AM
Unknown Object (File)
Wed, Aug 19, 4:09 PM
Unknown Object (File)
Wed, Aug 19, 4:03 PM
Unknown Object (File)
Tue, Aug 18, 8:35 PM
Unknown Object (File)
Tue, Aug 18, 8:33 PM
Subscribers

Details

Summary

Previously the code relied on the callers of efx_mcdi_mac_stats
to provide a DMA buffer or NULL depending on the action. Fix
this so that the DMA buffer is only passed in the request when
needed, and that an error is reported for a missing DMA buffer.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2018, 2:16 PM
This revision was automatically updated to reflect the committed changes.