Page MenuHomeFreeBSD
Differential D18167

sfxge(4): removing unneeded assert
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 15, 9:18 AM
Unknown Object (File)
Tue, May 14, 12:11 PM
Unknown Object (File)
Tue, May 14, 9:25 AM
Unknown Object (File)
Tue, May 14, 9:02 AM
Unknown Object (File)
Dec 20 2023, 7:33 AM
Unknown Object (File)
Aug 22 2023, 1:44 PM
Unknown Object (File)
Jun 20 2023, 7:35 AM
Unknown Object (File)
May 16 2023, 1:25 PM
View All 14 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341048: sfxge(4): removing unneeded assert
Summary

Remove ASSERT() from sfxge_link_mode_to_phy_cap() which causes an
unnecessary panic, even though the callers have proper error handling.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21025
Build 20388: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:37 AM
Harbormaster completed remote builds in B21025: Diff 50766.Nov 21 2018, 11:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2018, 1:02 PM
Closed by commit rS341048: sfxge(4): removing unneeded assert (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 27 2018, 1:02 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
1 line

Diff 50766

View Options

sys/dev/sfxge/sfxge_port.c

Loading...