Page MenuHomeFreeBSD
Differential D18167

sfxge(4): removing unneeded assert
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:37 AM.
Tags
None
Referenced Files
F174134017: D18167.id50766.diff
Wed, Sep 30, 8:17 PM
F174133344: D18167.id51194.diff
Wed, Sep 30, 8:13 PM
F174109633: D18167.diff
Wed, Sep 30, 4:53 PM
Unknown Object (File)
Mon, Sep 21, 6:03 AM
Unknown Object (File)
Wed, Sep 9, 9:37 PM
Unknown Object (File)
Wed, Sep 9, 9:37 PM
Unknown Object (File)
Tue, Sep 8, 11:25 PM
Unknown Object (File)
Wed, Sep 2, 5:52 PM
View All 97 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341048: sfxge(4): removing unneeded assert
Summary

Remove ASSERT() from sfxge_link_mode_to_phy_cap() which causes an
unnecessary panic, even though the callers have proper error handling.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:37 AM
Harbormaster completed remote builds in B21025: Diff 50766.Nov 21 2018, 11:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2018, 1:02 PM
Closed by commit rS341048: sfxge(4): removing unneeded assert (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 27 2018, 1:02 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
1 line

Diff 51194

View Options

head/sys/dev/sfxge/sfxge_port.c

Loading...