Page MenuHomeFreeBSD
Differential D1814

Simplify string mangling in ifmaybeload().
ClosedPublic
Actions

Authored by jhb on Feb 9 2015, 10:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 2, 4:26 AM
Unknown Object (File)
Sun, Nov 2, 12:04 AM
Unknown Object (File)
Sun, Nov 2, 12:04 AM
Unknown Object (File)
Sun, Nov 2, 12:04 AM
Unknown Object (File)
Sun, Nov 2, 12:04 AM
Unknown Object (File)
Sat, Nov 1, 7:59 PM
Unknown Object (File)
Mon, Oct 20, 3:49 AM
Unknown Object (File)
Tue, Oct 7, 9:30 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
rpaulo
Commits
rS279951: Simplify string mangling in ifmaybeload().
Summary

Use strlcpy() instead of a strcpy() and use strlcat() instead of
a strlcpy() with a magic number subtracted from the length.
Also, replace strncmp(..., strlen(foo) + 1) with strcmp(...).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

jhb updated this revision to Diff 3712.Feb 9 2015, 10:20 PM
jhb retitled this revision from to Simplify string mangling in ifmaybeload()..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: emaste.
jhb updated this revision to Diff 4201.Mar 12 2015, 10:13 PM

Compile.

Herald added a subscriber: imp. · View Herald TranscriptMar 12 2015, 10:13 PM
jhb added a comment.Mar 13 2015, 9:31 AM

I've runtested this now and it works fine.

rpaulo accepted this revision.Mar 13 2015, 9:36 AM
rpaulo added a reviewer: rpaulo.
This revision is now accepted and ready to land.Mar 13 2015, 9:36 AM
jhb closed this revision.Mar 13 2015, 9:45 AM
jhb updated this revision to Diff 4209.

Closed by commit rS279951 (authored by @jhb).

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
10 lines

Diff 3712

View Options

sbin/ifconfig/ifconfig.c

Loading...