Page MenuHomeFreeBSD
Differential D1814

Simplify string mangling in ifmaybeload().
ClosedPublic
Actions

Authored by jhb on Feb 9 2015, 10:20 PM.
Tags
None
Referenced Files
F174338790: D1814.id3712.diff
Fri, Oct 2, 12:45 PM
Unknown Object (File)
Wed, Sep 30, 9:48 PM
Unknown Object (File)
Sat, Sep 26, 9:19 PM
Unknown Object (File)
Sat, Sep 26, 11:36 AM
Unknown Object (File)
Fri, Sep 25, 12:33 PM
Unknown Object (File)
Thu, Sep 17, 6:59 AM
Unknown Object (File)
Thu, Sep 17, 6:59 AM
Unknown Object (File)
Thu, Sep 17, 6:57 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
rpaulo
Commits
rS279951: Simplify string mangling in ifmaybeload().
Summary

Use strlcpy() instead of a strcpy() and use strlcat() instead of
a strlcpy() with a magic number subtracted from the length.
Also, replace strncmp(..., strlen(foo) + 1) with strcmp(...).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jhb updated this revision to Diff 3712.Feb 9 2015, 10:20 PM
jhb retitled this revision from to Simplify string mangling in ifmaybeload()..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: emaste.
jhb updated this revision to Diff 4201.Mar 12 2015, 10:13 PM

Compile.

Herald added a subscriber: imp. · View Herald TranscriptMar 12 2015, 10:13 PM
jhb added a comment.Mar 13 2015, 9:31 AM

I've runtested this now and it works fine.

rpaulo accepted this revision.Mar 13 2015, 9:36 AM
rpaulo added a reviewer: rpaulo.
This revision is now accepted and ready to land.Mar 13 2015, 9:36 AM
jhb closed this revision.Mar 13 2015, 9:45 AM
jhb updated this revision to Diff 4209.

Closed by commit rS279951 (authored by @jhb).

Revision Contents
Changeset List

PathSize
head/
sbin/
ifconfig/
9 lines

Diff 4209

View Options

head/sbin/ifconfig/ifconfig.c

Loading...