Page MenuHomeFreeBSD

Configure interrupt on ARM when mapped
AbandonedPublic

Authored by zbb on Feb 9 2015, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 7:04 AM
Unknown Object (File)
Thu, Nov 28, 7:04 AM
Unknown Object (File)
Thu, Nov 28, 6:41 AM
Unknown Object (File)
Sat, Nov 23, 6:05 AM
Unknown Object (File)
Oct 23 2024, 6:48 AM
Unknown Object (File)
Oct 4 2024, 12:55 AM
Unknown Object (File)
Sep 21 2024, 10:40 AM
Unknown Object (File)
Sep 8 2024, 5:59 AM

Details

Reviewers
andrew
imp
ian
Summary

Do interrupt configuration as soon as is being mapped.

Submitted by: Wojciech Macek <wma@semihalf.com>
Obtained from: Semihalf

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zbb retitled this revision from to Configure interrupt on ARM when mapped.
zbb updated this object.
zbb edited the test plan for this revision. (Show Details)
zbb added reviewers: ian, andrew.
zbb added a subscriber: Unknown Object (MLST).
imp added a reviewer: imp.
imp added a subscriber: imp.

This is likely to cause bumps / races that aren't in the code. Thankfully, most of these aren't that large and are easy to manage.

sys/arm/arm/intr.c
122

extra braces

This revision is now accepted and ready to land.Feb 9 2015, 3:32 PM

I think this is completely wrong and the interrupt needs to be configured when it is activated, not when it is parsed/decoded. Consider for example a gpio pin interrupt... we wouldn't want to mess with the pin state while the fdt data is being parsed because that data could refer to a possible configuration which is never going to be activated, and the actual use of the pin in the configuration that is active could be something else (not even related to interrupts).

From intrng: Each interrupt controller gets FDT(property) data in his decode fdt() routine.
And it is entirely his responsibility, if he stores and uses it, immediately or later.
Note: In theory, FDT data may contain more information than just polarity and triggering

zbb planned changes to this revision.Mar 6 2015, 4:16 PM

I'm closing this. Corresponding issue will be resolved in the platform code.