Page MenuHomeFreeBSD
Differential D18094

sfxge(4): remove duplicate NVRAM asserts
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:21 AM.
Tags
None
Referenced Files
F171136480: D18094.id.diff
Tue, Sep 8, 10:40 PM
Unknown Object (File)
Sat, Sep 5, 8:06 AM
Unknown Object (File)
Thu, Sep 3, 7:41 PM
Unknown Object (File)
Thu, Sep 3, 5:34 PM
Unknown Object (File)
Thu, Sep 3, 4:07 PM
Unknown Object (File)
Thu, Sep 3, 3:19 PM
Unknown Object (File)
Wed, Sep 2, 7:37 AM
Unknown Object (File)
Wed, Sep 2, 1:18 AM
View All Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS340824: sfxge(4): remove duplicate NVRAM asserts
Summary

The checking performed in the ->envo_type_to_partn
internal method make these assertions unnecessary.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arybchik created this revision.Nov 21 2018, 11:21 AM
Harbormaster completed remote builds in B20950: Diff 50690.Nov 21 2018, 11:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2018, 10:21 AM
Closed by commit rS340824: sfxge(4): remove duplicate NVRAM asserts (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 23 2018, 10:21 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sfxge/
common/
1 line
27 lines
1 line

Diff 50974

View Options

head/sys/dev/sfxge/common/ef10_nvram.c

Loading...
View Options

head/sys/dev/sfxge/common/efx_nvram.c

Loading...
View Options

head/sys/dev/sfxge/common/siena_nvram.c

Loading...