Page MenuHomeFreeBSD
Differential D18067

sfxge(4): fix potential buffer overflow in Tx queue init
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 5 2024, 5:55 AM
Unknown Object (File)
Oct 2 2024, 5:07 PM
Unknown Object (File)
Oct 2 2024, 4:18 PM
Unknown Object (File)
Sep 21 2024, 9:10 PM
Unknown Object (File)
Sep 7 2024, 3:21 PM
Unknown Object (File)
Sep 5 2024, 2:03 PM
Unknown Object (File)
Aug 28 2024, 9:37 PM
Unknown Object (File)
Aug 28 2024, 9:37 PM
View All 28 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342408: MFC r340797
rS342305: MFC r340797
rS340797: sfxge(4): fix potential buffer overflow in Tx queue init
Summary

Improve error checking to avoid a caller overflowing the MCDI
request buffer if the requested TXQ size was excessively large.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20923
Build 20288: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:16 AM
Harbormaster completed remote builds in B20923: Diff 50663.Nov 21 2018, 11:16 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 23 2018, 7:50 AM
Closed by commit rS340797: sfxge(4): fix potential buffer overflow in Tx queue init (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 23 2018, 7:50 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
2 lines

Diff 50663

View Options

sys/dev/sfxge/common/ef10_tx.c

Loading...