The TCP RACK stack need to verify SEG.ACK first when in SYS-SENT state
ClosedPublic
Actions

Authored by tuexen on Nov 18 2018, 12:31 PM.

Details

Reviewers

rrs
lstewart
jason_eggnet.com

Group Reviewers

transport

Commits

rS341501: MFC r340782:
rS340782: A TCP stack is required to check SEG.ACK first, when processing a

Summary

According to RFC 793, page 66, a TCP need to check SEG.ACK first when handling a segment in SYN-SENT state. This patch enforces this for the TCP RACK stack.

Test Plan

Ensure all tests from rcv-syn-ack-syn-sent pass after setting

sysctl net.inet.tcp.functions_default=rack

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Nov 18 2018, 12:31 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptNov 18 2018, 12:31 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B20877: Diff 50558.Nov 18 2018, 12:31 PM

rrs accepted this revision.Nov 20 2018, 1:07 PM

This revision is now accepted and ready to land.Nov 20 2018, 1:07 PM

Closed by commit rS340782: A TCP stack is required to check SEG.ACK first, when processing a (authored by tuexen). · Explain WhyNov 22 2018, 8:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

tcp_stacks/

rack.c

9 lines

Diff 50930

View Options

head/sys/netinet/tcp_stacks/rack.c

The TCP RACK stack need to verify SEG.ACK first when in SYS-SENT stateClosedPublicActions