Page MenuHomeFreeBSD

Get rid of the special "default" value for dumpon's -g parameter.
ClosedPublic

Authored by markj on Nov 17 2018, 9:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 8:20 PM
Unknown Object (File)
Fri, Mar 22, 8:20 PM
Unknown Object (File)
Fri, Mar 22, 8:20 PM
Unknown Object (File)
Fri, Mar 22, 8:20 PM
Unknown Object (File)
Mar 9 2024, 8:13 AM
Unknown Object (File)
Feb 10 2024, 9:35 PM
Unknown Object (File)
Feb 2 2024, 10:48 PM
Unknown Object (File)
Jan 4 2024, 2:01 AM
Subscribers

Details

Reviewers
cem
Group Reviewers
manpages
Commits
rS340547: Change dumpon(8)'s handling of -g.
Summary

Instead, treat the absence of -g to mean that the default route is to be
selected. (And if there is no default route, dump directly to the
server.) The netdump client always attempts to ARP the server directly
anyway, so it doesn't hurt to always configure a gateway.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem added inline comments.
sbin/dumpon/dumpon.8
144–145 ↗(On Diff #50540)

I think being a little more redundant and mirroring the sentence structure might make it more clear. Something like:

If the
.Fl g
option is not specified and the system has a default route configured, the default route is used as the netdump gateway.
.Pp
If the
.Fl g
option is not specified and the system has
.Em no
default route configured, the
.Xr netdumpd 8
.Ar server
is assumed to be on the same link as the
.Ar client .

I don't feel strongly about it, though.

I'd drop the clause about packets being directly transmitted to the server; that follows logically from 'same link' and 'no gateaway' for anyone familiar with IP networking, and for anyone who isn't familiar, the clause is kind of meaningless anyway.

This revision is now accepted and ready to land.Nov 18 2018, 12:06 AM
markj marked an inline comment as done.
  • Address feedback.
This revision now requires review to proceed.Nov 18 2018, 12:29 AM
markj added inline comments.
sbin/dumpon/dumpon.8
144–145 ↗(On Diff #50540)

I didn't copy the suggestion exactly, but it's pretty similar.

Looks great to me, thanks!

This revision is now accepted and ready to land.Nov 18 2018, 12:47 AM
This revision was automatically updated to reflect the committed changes.