Page MenuHomeFreeBSD

add devel/onscripter{,-1byte} ports
ClosedPublic

Authored by jbeich on Feb 7 2015, 9:42 PM.

Details

Reviewers
bapt
flo
Summary

Add new port: devel/onscripter and devel/onscripter-1byte

PR: 196654
Approved by: ??? (mentor)

Open source clone of NScripter, a game engine used to create and
perform visual novels.

WWW: http://onscripter.sourceforge.jp/onscripter.html

-1byte port is modeled after Debian package.
No direct dependency on libpthread even among vendor LDFLAGS but it's pulled by sdl.pc and ignored by -Wl,--as-needed. See poudriere logs.
Test Plan

Runtime tested within 8.4R amd64 poudriere jail against japanese/narcissu2 and narcissu (1st) from insani.org.

poudriere testport -P logs:
onscripter-20150208 + -1byte for 8.4R amd64
onscripter-20150208 + -1byte for 9.3R i386
onscripter-20150208 + -1byte for 10.0R amd64
onscripter-20150208 + -1byte for 10.1R i386

devel/onscripter$ portlint -AC
WARN: Makefile: [48]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
0 fatal errors and 2 warnings found.
devel/onscripter-1byte$ portlint -AC
WARN: Makefile: LUA is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MLUA appears.
WARN: Makefile: PDA is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MPDA appears.
WARN: Makefile: UTF8 is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MUTF8 appears.
FATAL: Makefile: extra item "PLIST_FILES" placed in the LICENSE section.
1 fatal error and 3 warnings found.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

jbeich retitled this revision from to add devel/onscripter{,-1byte} ports.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added reviewers: bapt, flo.
bapt edited edge metadata.

That looks good to me just some cosmectic comment about '?=' but that is harmless

devel/onscripter/Makefile
35

Why '?='

This revision is now accepted and ready to land.Feb 7 2015, 9:50 PM
devel/onscripter/Makefile
35

I've tried to limit the number of options. It's slightly inspired by PkgSrc to allow user or slave port set their own -DFOO.

  • ENGLISH without -DFORCE_1BYTE_CHAR
  • PDA with -DPDA_WIDTH=640 instead
  • UTF8 without -DUTF8_CAPTION or without -DUTF8_FILESYSTEM