Page MenuHomeFreeBSD

Fix first-packet completion
ClosedPublic

Authored by shurd on Nov 9 2018, 7:35 PM.

Details

Summary

The first packet after the ring is initialized was never
completed as isc_txd_credits_update() would not include it in the
count of completed packets. This caused netmap to never complete
a batch. See PR 233022 for more details.

Test Plan

Have lev confirm fix.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

shurd created this revision.Nov 9 2018, 7:35 PM
lev accepted this revision.Nov 9 2018, 9:43 PM

Yep, it helps, at least at em

This revision is now accepted and ready to land.Nov 9 2018, 9:43 PM
Closed by commit rS340310: Fix first-packet completion (authored by shurd, committed by ). · Explain WhyNov 9 2018, 10:19 PM
This revision was automatically updated to reflect the committed changes.