Fix first-packet completion
ClosedPublic
Actions

Authored by shurd on Nov 9 2018, 7:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jul 5, 4:41 AM

	Unknown Object (File)
	Sat, Jul 4, 11:26 PM

	Unknown Object (File)
	Fri, Jul 3, 4:19 AM

	Unknown Object (File)
	Thu, Jul 2, 4:33 AM

	Unknown Object (File)
	Tue, Jun 23, 3:25 AM

	Unknown Object (File)
	Fri, Jun 19, 10:14 PM

	Unknown Object (File)
	Fri, Jun 19, 2:35 PM

	Unknown Object (File)
	Wed, Jun 17, 12:56 PM

View All Files

Subscribers

imp

Details

Reviewers

lev
sbruno
erj
jeb

Commits

rS340366: MFC r340310:
rS340310: Fix first-packet completion

Summary

The first packet after the ring is initialized was never
completed as isc_txd_credits_update() would not include it in the
count of completed packets. This caused netmap to never complete
a batch. See PR 233022 for more details.

Test Plan

Have lev confirm fix.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

shurd created this revision.Nov 9 2018, 7:35 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 9 2018, 7:35 PM

Harbormaster completed remote builds in B20727: Diff 50227.Nov 9 2018, 7:35 PM

Yep, it helps, at least at em

This revision is now accepted and ready to land.Nov 9 2018, 9:43 PM

Closed by commit rS340310: Fix first-packet completion (authored by shurd). · Explain WhyNov 9 2018, 10:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

e1000/

em_txrx.c

6 lines

igb_txrx.c

6 lines

Diff 50239

View Options

head/sys/dev/e1000/em_txrx.c