Page MenuHomeFreeBSD
Differential D17870

cxgbe netmap: Avoid too frequent flush of CIDX by the NIC
Needs ReviewPublic
Actions

Authored by bwicht_verisign.com on Nov 6 2018, 1:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 2 2024, 11:09 AM
Unknown Object (File)
Sep 21 2024, 6:10 AM
Unknown Object (File)
Sep 16 2024, 8:03 AM
Unknown Object (File)
Sep 9 2024, 1:23 AM
Unknown Object (File)
Sep 5 2024, 2:21 PM
Unknown Object (File)
Aug 5 2024, 8:24 PM
Unknown Object (File)
Jul 29 2024, 7:00 PM
Unknown Object (File)
Jul 20 2024, 11:10 PM
View All 22 Files
Subscribers
ae
jch

Details

Reviewers
np
Summary

By default, CIDX (consumer index) is flushed by the NIC after every
update. That means a PCI transaction for each TX packet. By setting the
threshold to 32, the amount of PCI traffic is significantly reduced.

Submitted by: Marc De La Gueronniere <mdelagueronniere@verisign.com>
MFC after: 1 week
Sponsored by: Verisign, Inc.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20660
Build 20075: arc lint + arc unit

Event Timeline

bwicht_verisign.com created this revision.Nov 6 2018, 1:49 PM
Herald added a subscriber: ae. · View Herald TranscriptNov 6 2018, 1:49 PM
Harbormaster completed remote builds in B20660: Diff 50073.Nov 6 2018, 1:49 PM
np added a comment.Nov 6 2018, 8:34 PM

lazy_tx_credit_flush in the driver is supposed to avoid the situation you described. Try setting it to 1 if it isn't already and see if that helps.

jch added a subscriber: jch.Nov 6 2018, 9:29 PM
bwicht_verisign.com added a comment.Nov 7 2018, 9:41 AM
In D17870#381915, @np wrote:

lazy_tx_credit_flush in the driver is supposed to avoid the situation you described. Try setting it to 1 if it isn't already and see if that helps.

In fact, we are using lazy_tx_credit_flush=1

Does this change have no impact when lazy_tx_credit_flush is used?

Revision Contents
Changeset List

PathSize
sys/
dev/
cxgbe/
1 line

Diff 50073

View Options

sys/dev/cxgbe/t4_netmap.c

Loading...