Page MenuHomeFreeBSD

Set PTE_A and PTE_D for user mappings in pmap_enter().
ClosedPublic

Authored by jhb on Oct 31 2018, 6:41 PM.
Tags
None
Referenced Files
F86811625: D17782.id49908.diff
Tue, Jun 25, 11:07 PM
Unknown Object (File)
Mar 25 2024, 12:30 AM
Unknown Object (File)
Mar 21 2024, 5:54 PM
Unknown Object (File)
Feb 5 2024, 7:00 AM
Unknown Object (File)
Dec 20 2023, 2:52 AM
Unknown Object (File)
Aug 24 2023, 12:05 AM
Unknown Object (File)
Aug 17 2023, 7:57 PM
Unknown Object (File)
Aug 8 2023, 12:53 AM
Subscribers

Details

Summary

This assumes that an access according to the prot in 'flags' triggered
a fault and is going to be retried after the fault returns, so the two
flags are set preemptively to avoid refaulting on the retry.

While here, only bother setting PTE_D for kernel mappings in pmap_enter
for writable mappings.

Test Plan
  • booted qemu and ran various programs

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
sys/riscv/riscv/pmap.c
2093 ↗(On Diff #49840)

Should be new_l3, as you corrected in D17783.

This revision is now accepted and ready to land.Nov 1 2018, 2:39 PM
jhb marked an inline comment as done.Nov 1 2018, 10:17 PM
This revision was automatically updated to reflect the committed changes.