Don't allow debuggers to modify SSTATUS, only to read it.
ClosedPublic
Actions

Authored by jhb on Oct 30 2018, 11:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 3:40 PM

	Unknown Object (File)
	Oct 3 2024, 9:38 PM

	Unknown Object (File)
	Sep 19 2024, 10:32 AM

	Unknown Object (File)
	Sep 18 2024, 11:03 PM

	Unknown Object (File)
	Sep 17 2024, 2:08 PM

	Unknown Object (File)
	Sep 16 2024, 12:54 PM

	Unknown Object (File)
	Sep 6 2024, 1:30 AM

	Unknown Object (File)
	Sep 3 2024, 2:12 PM

View All 18 Files

Subscribers

imp

Details

Reviewers

br
markj

Commits

rS340027: Don't allow debuggers to modify SSTATUS, only to read it.

Test Plan

basic gdb of live processes still works. Trying to set $status in gdb doesn't now fails to do anything. (I didn't actually try it on an old kernel to see what would have happened, but I supsect it wouldn't have worked out well.)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 30 2018, 11:45 PM

Harbormaster completed remote builds in B20524: Diff 49811.Oct 30 2018, 11:45 PM

markj accepted this revision.Oct 31 2018, 7:01 PM

This revision is now accepted and ready to land.Oct 31 2018, 7:01 PM

Closed by commit rS340027: Don't allow debuggers to modify SSTATUS, only to read it. (authored by jhb). · Explain WhyNov 1 2018, 10:13 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2018, 10:13 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

machdep.c

1 line

Diff 49906

View Options

head/sys/riscv/riscv/machdep.c

Don't allow debuggers to modify SSTATUS, only to read it.ClosedPublicActions