Differential D17769

Implement ptrace_set_pc() and fail PT_*STEP requests explicitly.
ClosedPublic
Actions

Authored by jhb on Oct 30 2018, 11:27 PM.

Tags

None

Referenced Files

	F171402722: D17769.id49905.diff
	Thu, Sep 10, 10:38 PM

	Unknown Object (File)
	Sun, Sep 6, 5:29 PM

	Unknown Object (File)
	Sun, Sep 6, 2:32 AM

	Unknown Object (File)
	Sun, Sep 6, 2:20 AM

	Unknown Object (File)
	Sat, Sep 5, 7:35 AM

	Unknown Object (File)
	Sat, Sep 5, 12:03 AM

	Unknown Object (File)
	Fri, Sep 4, 9:25 AM

	Unknown Object (File)
	Thu, Sep 3, 4:42 PM

View All 92 Files

Subscribers

Details

Reviewers

br
markj

Commits

rS340025: Implement ptrace_set_pc() and fail PT_*STEP requests explicitly.

Test Plan

This just gives different failures for tests using PT_STEP in ptrace_test. Eventually tests using PT_STEP should report a test as skipped if PT_STEP fails with this error.
We have no test for ptrace_set_pc() and nothing really uses it, but it was simple to implement.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 30 2018, 11:27 PM

Harbormaster completed remote builds in B20522: Diff 49809.Oct 30 2018, 11:27 PM

markj accepted this revision.Oct 31 2018, 7:01 PM

This revision is now accepted and ready to land.Oct 31 2018, 7:01 PM

Closed by commit rS340025: Implement ptrace_set_pc() and fail PT_*STEP requests explicitly. (authored by jhb). · Explain WhyNov 1 2018, 10:11 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2018, 10:11 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

riscv/

6 lines

Diff 49905

head/sys/riscv/riscv/machdep.c

Loading...