Page MenuHomeFreeBSD
Differential D17761

PR230720: strptime: allow blank-padding for %k and %l
ClosedPublic
Actions

Authored by yuripv on Oct 30 2018, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 5, 4:21 AM
Unknown Object (File)
Thu, Apr 24, 3:24 PM
Unknown Object (File)
Thu, Apr 24, 2:50 PM
Unknown Object (File)
Wed, Apr 23, 1:43 PM
Unknown Object (File)
Mon, Apr 21, 1:28 AM
Unknown Object (File)
Sun, Apr 20, 11:18 PM
Unknown Object (File)
Sun, Apr 20, 7:30 AM
Unknown Object (File)
Sun, Apr 20, 5:58 AM
View All 85 Files
Subscribers
imp
kib
Contributor Reviews (src)

Details

Reviewers
ngie
Commits
rS340106: strptime: make %k and %l specifiers match their description in
Summary

strptime: allow blank-padding for %k and %l. Both are extensions and documented as being blank-padded in strftime(3).

Test Plan

Test cases added to lib/libc/tests/time.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuripv created this revision.Oct 30 2018, 12:49 PM
Herald added a reviewer: ngie. · View Herald TranscriptOct 30 2018, 12:49 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
kib added inline comments.Oct 30 2018, 5:09 PM
lib/libc/stdtime/strptime.c
285 ↗(On Diff #49792)

I must admit that this is somewhat unusual way to write the cast. *(unsigned char *)buf is more typical.

yuripv marked an inline comment as done.Oct 30 2018, 5:14 PM
yuripv added inline comments.
lib/libc/stdtime/strptime.c
285 ↗(On Diff #49792)

Should I fix it or leave it as it seems to follow other casts in this file?

kib added inline comments.Oct 30 2018, 5:35 PM
lib/libc/stdtime/strptime.c
285 ↗(On Diff #49792)

It was a note, not the change request. It is indeed looks unusual.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2018, 11:37 PM
Closed by commit rS340106: strptime: make %k and %l specifiers match their description in (authored by yuripv). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
contrib/
netbsd-tests/
lib/
libc/
time/
13 lines
lib/
libc/
stdtime/
17 lines

Diff 49980

View Options

head/contrib/netbsd-tests/lib/libc/time/t_strptime.c

Loading...
View Options

head/lib/libc/stdtime/strptime.c

Loading...