Paths

Table of Contentst

Differential D17761

PR230720: strptime: allow blank-padding for %k and %l
ClosedPublic
Actions

Authored by yuripv on Oct 30 2018, 12:49 PM.

Details

Reviewers

ngie

Commits

rS340106: strptime: make %k and %l specifiers match their description in

Summary

strptime: allow blank-padding for %k and %l. Both are extensions and documented as being blank-padded in strftime(3).

Test Plan

Test cases added to lib/libc/tests/time.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuripv created this revision.Oct 30 2018, 12:49 PM

Herald added a reviewer: ngie. · View Herald TranscriptOct 30 2018, 12:49 PM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript

kib added inline comments.Oct 30 2018, 5:09 PM

lib/libc/stdtime/strptime.c
285 ↗	(On Diff #49792)	I must admit that this is somewhat unusual way to write the cast. `(unsigned char )buf` is more typical.

yuripv marked an inline comment as done.Oct 30 2018, 5:14 PM

yuripv added inline comments.

lib/libc/stdtime/strptime.c
285 ↗	(On Diff #49792)	Should I fix it or leave it as it seems to follow other casts in this file?

kib added inline comments.Oct 30 2018, 5:35 PM

lib/libc/stdtime/strptime.c
285 ↗	(On Diff #49792)	It was a note, not the change request. It is indeed looks unusual.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 3 2018, 11:37 PM

Closed by commit rS340106: strptime: make %k and %l specifiers match their description in (authored by yuripv). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

contrib/

netbsd-tests/

lib/

libc/

time/

t_strptime.c

13 lines

lib/

libc/

stdtime/

strptime.c

17 lines

Diff 49980

View Options

head/contrib/netbsd-tests/lib/libc/time/t_strptime.c