pf: Count holes rather than fragments for reassembly
ClosedPublic
Actions

Authored by kp on Oct 28 2018, 6:29 AM.

Details

Reviewers

Group Reviewers

Commits

rG1d6a2a742c1b: pf: Count holes rather than fragments for reassembly
rS340060: pf: Count holes rather than fragments for reassembly

Summary

Avoid traversing the list of fragment entris to check whether the
pf(4) reassembly is complete. Instead count the holes that are
created when inserting a fragment. If there are no holes left, the
fragments are continuous.

Obtained from: OpenBSD

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Oct 28 2018, 6:29 AM

Herald added a subscriber: farrokhi. · View Herald TranscriptOct 28 2018, 6:29 AM

Harbormaster completed remote builds in B20479: Diff 49717.Oct 28 2018, 6:29 AM

kp edited the summary of this revision. (Show Details)Oct 28 2018, 6:30 AM

kp added a reviewer: network.

kp set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 28 2018, 6:30 AM

eri accepted this revision.Oct 30 2018, 5:46 PM

This revision is now accepted and ready to land.Oct 30 2018, 5:46 PM

Closed by commit rS340060: pf: Count holes rather than fragments for reassembly (authored by kp). · Explain WhyNov 2 2018, 3:24 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG1d6a2a742c1b: pf: Count holes rather than fragments for reassembly.Feb 28 2021, 4:05 PM

Herald added a subscriber: melifaro. · View Herald TranscriptFeb 28 2021, 4:05 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

netpfil/

pf/

pf_norm.c

83 lines

Diff 49937

View Options

head/sys/netpfil/pf/pf_norm.c

pf: Count holes rather than fragments for reassemblyClosedPublicActions