Page MenuHomeFreeBSD

x11/guake: update to version 3.4.0.
ClosedPublic

Authored by rigoletto on Oct 27 2018, 9:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 5:20 PM
Unknown Object (File)
Feb 17 2024, 12:25 AM
Unknown Object (File)
Feb 16 2024, 10:58 PM
Unknown Object (File)
Feb 16 2024, 10:58 PM
Unknown Object (File)
Feb 16 2024, 10:57 PM
Unknown Object (File)
Feb 16 2024, 10:57 PM
Unknown Object (File)
Feb 16 2024, 10:57 PM
Unknown Object (File)
Feb 16 2024, 10:57 PM
Subscribers
None

Details

Summary

PR: 232163

  • update to version 3.4.0.
  • give maintainership to the submitter

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20557
Build 19978: arc lint + arc unit

Event Timeline

rigoletto edited the summary of this revision. (Show Details)

I would merge the 10-ish import locale->import gettext patches into one

x11/guake/Makefile
35–37

^ this should appear after the definition of the Option.

x11/guake/pkg-plist
124–212

^3.4.0 -> %%PORTVERSION%% -- that could lead to fewer changes on upgrade

For some reason %%PORTVERSION%% isn't working as expected in pkg-plist. :-/

I would merge the 10-ish import locale->import gettext patches into one

^ alternatively, you could also use a REINPLACE_CMD to sed /import/s|locale|gettext

For some reason %%PORTVERSION%% isn't working as expected in pkg-plist. :-/

See Chapter 8

Fixed. I thought all default variables would work automatically as PLIST_SUB.

Thanks!

tcberner requested changes to this revision.Nov 2 2018, 7:49 AM

You need to disable flavors or give it a unique pkg name per flavor.

Also the 36in the plist look python-versiony. Is there no issue for another py version?

This revision now requires changes to proceed.Nov 2 2018, 7:49 AM

You need to disable flavors or give it a unique pkg name per flavor.

Also the 36in the plist look python-versiony. Is there no issue for another py version?

Well, different FLAVORS of Guake cannot be installed together, and it is supposedly to behave like a regular desktop software, so I think it is better to just allow the py36 then.

Make Guake py36 only.

Why 36? I would let people use their default version :)

Make Guake py36 only.

Rather than forcing your chosen version, you should problby use USE_PYTHON=noflavors

Make Guake py36 only.

Why 36? I would let people use their default version :)

Because 36 is the default one. ^^

Make Guake py36 only.

Rather than forcing your chosen version, you should problby use USE_PYTHON=noflavors

I wasn't aware noflavors is also possible for python.

Thanks!

This revision is now accepted and ready to land.Nov 10 2018, 10:29 AM
This revision was automatically updated to reflect the committed changes.