Page MenuHomeFreeBSD
Differential D17726

x11/guake: update to version 3.4.0.
ClosedPublic
Actions

Authored by rigoletto on Oct 27 2018, 9:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 2:38 AM
Unknown Object (File)
Dec 3 2024, 4:32 AM
Unknown Object (File)
Dec 1 2024, 2:10 PM
Unknown Object (File)
Dec 1 2024, 2:10 PM
Unknown Object (File)
Dec 1 2024, 2:10 PM
Unknown Object (File)
Dec 1 2024, 2:10 PM
Unknown Object (File)
Dec 1 2024, 2:10 PM
Unknown Object (File)
Dec 1 2024, 2:10 PM
View All Files
Subscribers
None

Details

Reviewers
tcberner
mat
nivit
Group Reviewers
gnome
Commits
rP484632: x11/guake: Update to version 3.4.0
Summary

PR: 232163

  • update to version 3.4.0.
  • give maintainership to the submitter

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rigoletto created this revision.Oct 27 2018, 9:14 PM
Harbormaster completed remote builds in B20471: Diff 49704.Oct 27 2018, 9:14 PM
rigoletto added a reviewer: gnome.Oct 27 2018, 9:17 PM
rigoletto edited the summary of this revision. (Show Details)
tcberner added a comment.Oct 27 2018, 9:26 PM

I would merge the 10-ish import locale->import gettext patches into one

x11/guake/Makefile
35 ↗(On Diff #49704)

^ this should appear after the definition of the Option.

x11/guake/pkg-plist
124 ↗(On Diff #49704)

^3.4.0 -> %%PORTVERSION%% -- that could lead to fewer changes on upgrade

rigoletto updated this revision to Diff 49708.Oct 27 2018, 9:33 PM

Fixing.

Thanks.

Harbormaster completed remote builds in B20474: Diff 49708.Oct 27 2018, 9:33 PM
rigoletto marked 2 inline comments as done.Oct 27 2018, 9:33 PM
rigoletto updated this revision to Diff 49859.Nov 1 2018, 1:45 AM

For some reason %%PORTVERSION%% isn't working as expected in pkg-plist. :-/

Harbormaster completed remote builds in B20557: Diff 49859.Nov 1 2018, 1:45 AM
tcberner added a comment.Nov 1 2018, 5:13 AM
In D17726#378869, @tcberner wrote:

I would merge the 10-ish import locale->import gettext patches into one

^ alternatively, you could also use a REINPLACE_CMD to sed /import/s|locale|gettext

In D17726#380216, @rigoletto wrote:

For some reason %%PORTVERSION%% isn't working as expected in pkg-plist. :-/

See Chapter 8

rigoletto updated this revision to Diff 49900.Nov 1 2018, 7:09 PM

Fixed. I thought all default variables would work automatically as PLIST_SUB.

Thanks!

Harbormaster completed remote builds in B20584: Diff 49900.Nov 1 2018, 7:09 PM
tcberner requested changes to this revision.Nov 2 2018, 7:49 AM

You need to disable flavors or give it a unique pkg name per flavor.

Also the 36in the plist look python-versiony. Is there no issue for another py version?

This revision now requires changes to proceed.Nov 2 2018, 7:49 AM
rigoletto added a comment.Nov 2 2018, 9:43 PM
In D17726#380705, @tcberner wrote:

You need to disable flavors or give it a unique pkg name per flavor.

Also the 36in the plist look python-versiony. Is there no issue for another py version?

Well, different FLAVORS of Guake cannot be installed together, and it is supposedly to behave like a regular desktop software, so I think it is better to just allow the py36 then.

rigoletto updated this revision to Diff 49965.Nov 3 2018, 6:18 AM

Make Guake py36 only.

Harbormaster completed remote builds in B20604: Diff 49965.Nov 3 2018, 6:18 AM
tcberner added a comment.Nov 4 2018, 4:08 PM
In D17726#380953, @rigoletto wrote:

Make Guake py36 only.

Why 36? I would let people use their default version :)

In D17726#380953, @rigoletto wrote:

Make Guake py36 only.

Rather than forcing your chosen version, you should problby use USE_PYTHON=noflavors

rigoletto added a comment.Nov 4 2018, 8:06 PM
In D17726#381194, @tcberner wrote:
In D17726#380953, @rigoletto wrote:

Make Guake py36 only.

Why 36? I would let people use their default version :)

Because 36 is the default one. ^^

In D17726#380953, @rigoletto wrote:

Make Guake py36 only.

Rather than forcing your chosen version, you should problby use USE_PYTHON=noflavors

I wasn't aware noflavors is also possible for python.

Thanks!

rigoletto updated this revision to Diff 50008.Nov 4 2018, 8:20 PM

Add noflavors

Harbormaster completed remote builds in B20627: Diff 50008.Nov 4 2018, 8:20 PM
rigoletto updated this revision to Diff 50052.Nov 6 2018, 12:50 AM

Set python:3.5-3.6.

Harbormaster completed remote builds in B20652: Diff 50052.Nov 6 2018, 12:50 AM
rigoletto updated this revision to Diff 50082.Nov 6 2018, 7:13 PM

Reverting: python:3.5+

Harbormaster completed remote builds in B20665: Diff 50082.Nov 6 2018, 7:13 PM
tcberner accepted this revision.Nov 10 2018, 10:29 AM

Looks good to me.

This revision is now accepted and ready to land.Nov 10 2018, 10:29 AM
Closed by commit rP484632: x11/guake: Update to version 3.4.0 (authored by rigoletto). · Explain WhyNov 10 2018, 7:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 50265

View Options

head/x11/guake/Makefile

Loading...
View Options

head/x11/guake/distinfo

Loading...
View Options

head/x11/guake/files/patch-data_Makefile.am

Loading...
View Options

head/x11/guake/files/patch-data__guake-prefs.desktop.in

Loading...
View Options

head/x11/guake/files/patch-data__guake.desktop.in

Loading...
View Options

head/x11/guake/files/patch-guake_paths.py

Loading...
View Options

head/x11/guake/files/patch-guake_terminal.py

Loading...
View Options

head/x11/guake/pkg-plist

Loading...