x11/guake: update to version 3.4.0.

[rigoletto]

Summary

PR: 232163

• update to version 3.4.0.
• give maintainership to the submitter

[tcberner]

I would merge the 10-ish import locale->import gettext patches into one

x11/guake/Makefile

35 ↗

(On Diff #49704)

^ this should appear after the definition of the Option.

x11/guake/pkg-plist

124 ↗

(On Diff #49704)

^3.4.0 -> %%PORTVERSION%% -- that could lead to fewer changes on upgrade

[rigoletto]

Fixing.

Thanks.

[rigoletto]

For some reason %%PORTVERSION%% isn't working as expected in pkg-plist. :-/

[tcberner]

In D17726#378869, @tcberner wrote:

I would merge the 10-ish import locale->import gettext patches into one

^ alternatively, you could also use a REINPLACE_CMD to sed /import/s|locale|gettext

In D17726#380216, @rigoletto wrote:

For some reason %%PORTVERSION%% isn't working as expected in pkg-plist. :-/

See Chapter 8

[rigoletto]

Fixed. I thought all default variables would work automatically as PLIST_SUB.

Thanks!

[tcberner]

You need to disable flavors or give it a unique pkg name per flavor.

Also the 36in the plist look python-versiony. Is there no issue for another py version?

[rigoletto]

In D17726#380705, @tcberner wrote:

You need to disable flavors or give it a unique pkg name per flavor.

Also the 36in the plist look python-versiony. Is there no issue for another py version?

Well, different FLAVORS of Guake cannot be installed together, and it is supposedly to behave like a regular desktop software, so I think it is better to just allow the py36 then.

[rigoletto]

Make Guake py36 only.

[tcberner]

In D17726#380953, @rigoletto wrote:

Make Guake py36 only.

Why 36? I would let people use their default version :)

In D17726#380953, @rigoletto wrote:

Make Guake py36 only.

Rather than forcing your chosen version, you should problby use USE_PYTHON=noflavors

[rigoletto]

In D17726#381194, @tcberner wrote:

In D17726#380953, @rigoletto wrote:

Make Guake py36 only.

Why 36? I would let people use their default version :)

Because 36 is the default one. ^^

In D17726#380953, @rigoletto wrote:

Make Guake py36 only.

Rather than forcing your chosen version, you should problby use USE_PYTHON=noflavors

I wasn't aware noflavors is also possible for python.

Thanks!

[rigoletto]

Add noflavors

[rigoletto]

Set python:3.5-3.6.

[rigoletto]

Reverting: python:3.5+

[tcberner]

Looks good to me.