vbsc_ident buffer accessed out of bounds.
AbandonedPublic
Actions

Authored by araujo on Oct 26 2018, 11:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 20 2023, 6:15 AM

	Unknown Object (File)
	Dec 18 2023, 3:14 AM

	Unknown Object (File)
	Sep 24 2023, 10:00 AM

	Unknown Object (File)
	Sep 2 2023, 12:53 PM

	Unknown Object (File)
	Aug 3 2023, 8:20 AM

	Unknown Object (File)
	Jun 19 2023, 7:06 PM

	Unknown Object (File)
	Apr 25 2023, 6:37 PM

	Unknown Object (File)
	Apr 19 2023, 4:56 PM

View All 11 Files

Subscribers

imp

Details

Reviewers

rgrimes

Group Reviewers

bhyve

Summary

In src/pci_virtio_block.c, sc->vbsc_ident buffer accessed out of bounds.
https://github.com/mist64/xhyve/pull/24 increases the buffer size by one and also switches to snprintf.

Originally it was a patch for xhyve project.

Test Plan

Tested with Linux Fedora and FreeBSD Head as guest.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20442
Build 19879: arc lint + arc unit

Event Timeline

araujo created this revision.Oct 26 2018, 11:26 AM

Herald added a reviewer: rgrimes. · View Herald TranscriptOct 26 2018, 11:26 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B20442: Diff 49646.Oct 26 2018, 11:26 AM

araujo added a reviewer: bhyve.Oct 26 2018, 11:27 AM

Committed at: r340707

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_ahci.c

9 lines

pci_virtio_block.c

5 lines

Diff 49646

View Options

usr.sbin/bhyve/pci_ahci.c