Page MenuHomeFreeBSD

Reformat syscalls.master for better readability.
ClosedPublic

Authored by brooks on Oct 25 2018, 7:25 PM.

Details

Summary

This takes advantage of two recents changes to makesyscalls.sh:
r328598: Permit a range of syscall numbers for UNIMPL
r339624: Remove the need for backslashes in syscalls.master

Syscall declerations are now split across multiple lines with the
syscall name and variables each on seperate lines (with an exception for
syscalls taking no arguments.)

Proposed on freebsd-arch October 9th to resounding silence.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

brooks created this revision.Oct 25 2018, 7:25 PM
brooks updated this revision to Diff 49628.Oct 25 2018, 7:30 PM
  • Switch to <type/flags><space>{. Was previously inconsistant.

This diff basically changes every non-comment line so it's best reviewed in concept only or as an applied patch.

The generated output from make sysent has no changes.

imp added a comment.Oct 30 2018, 8:36 PM

This looks sane to me. At least the few places I spot-checked did. And it passes the 'not too terrible to look at' test too, which is nice.

imp accepted this revision.Oct 30 2018, 8:36 PM
This revision is now accepted and ready to land.Oct 30 2018, 8:36 PM
This revision was automatically updated to reflect the committed changes.