Fix stand/ build after r339671.
ClosedPublic
Actions

Authored by kib on Oct 23 2018, 10:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 23, 11:22 AM

	Unknown Object (File)
	Sep 4 2025, 10:06 PM

	Unknown Object (File)
	Sep 2 2025, 3:45 PM

	Unknown Object (File)
	Sep 2 2025, 12:28 PM

	Unknown Object (File)
	Aug 14 2025, 6:11 AM

	Unknown Object (File)
	Aug 8 2025, 6:29 PM

	Unknown Object (File)
	Aug 8 2025, 11:41 AM

	Unknown Object (File)
	Aug 1 2025, 9:16 PM

View All 60 Files

Subscribers

None

Details

Reviewers

imp
kevans

Commits

rS339673: Fix stand/ build after r339671.

Summary

ffs_subr.c requires calculate_crc32c() from libkern. Unfortunately we cannot just add libkern/crc32.c to libstand because crc32.o is already compiled from contrib/zlib/crc32.c. Use the include trick to rename the source.

Note that libstand also provides crc32.c which seems to be unused.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 23 2018, 10:44 PM

Harbormaster completed remote builds in B20376: Diff 49535.Oct 23 2018, 10:44 PM

This will fix the build. I'll look into the unused crc32 and sort out what can/should be common here after this commit.

This revision is now accepted and ready to land.Oct 23 2018, 10:52 PM

Closed by commit rS339673: Fix stand/ build after r339671. (authored by kib). · Explain WhyOct 23 2018, 11:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

libsa/

Makefile

4 lines

crc32_libkern.c

3 lines

Diff 49536

View Options

head/stand/libsa/Makefile