Page MenuHomeFreeBSD
Differential D17649

sort {delete,check}-old*
ClosedPublic
Actions

Authored by emaste on Oct 22 2018, 6:44 PM.
Tags
None
Referenced Files
F169649938: D17649.id49456.diff
Wed, Sep 2, 4:26 AM
Unknown Object (File)
Tue, Sep 1, 12:20 PM
Unknown Object (File)
Mon, Aug 31, 12:03 PM
Unknown Object (File)
Mon, Aug 31, 3:53 AM
Unknown Object (File)
Mon, Aug 31, 2:35 AM
Unknown Object (File)
Sun, Aug 30, 11:59 AM
Unknown Object (File)
Thu, Aug 27, 5:06 PM
Unknown Object (File)
Thu, Aug 27, 3:52 AM
View All Files
Subscribers
None

Details

Reviewers
imp
brooks
Commits
rS339645: sort {delete,check}-old* output
Summary

It is more convenient to review old libraries, files, and directories in order.

Sort check-* after checking for existence of files for efficiency, and because /usr/lib/debug entries are added while iterating over the list.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Oct 22 2018, 6:44 PM
brooks accepted this revision.Oct 22 2018, 9:18 PM

This seems fine.

As an aside: this code is appallingly slow and needs to be replaced with something that doesn't require 8+ execs per file that might exist.

This revision is now accepted and ready to land.Oct 22 2018, 9:18 PM
Closed by commit rS339645: sort {delete,check}-old* output (authored by emaste). · Explain WhyOct 23 2018, 1:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
14 lines

Diff 49499

View Options

head/Makefile.inc1

Loading...