Page MenuHomeFreeBSD
Differential D17573

Fix www/mod_rpaf sample config file.
ClosedPublic
Actions

Authored by madpilot on Oct 15 2018, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 1:33 PM
Unknown Object (File)
Thu, Apr 18, 3:15 AM
Unknown Object (File)
Wed, Apr 17, 1:54 AM
Unknown Object (File)
Tue, Apr 16, 11:18 AM
Unknown Object (File)
Fri, Apr 12, 5:54 PM
Unknown Object (File)
Fri, Apr 12, 5:54 PM
Unknown Object (File)
Fri, Apr 12, 5:54 PM
Unknown Object (File)
Fri, Apr 12, 3:23 AM
View All 35 Files
Subscribers
joneum
mat

Details

Reviewers
ohauer
brnrd
Commits
rP485946: www/mod_rpaf: The mod_rpaf configuration sample contains an error which makes…
Summary

www/mod_rpaf: The mod_rpaf configuration sample contains an error which makes it non functional as installed.

While here fixed an error in PLIST_FILES and a portling warning.

PR: 233444
Approved by:
With hat: apache
Differential_Revision: https://reviews.freebsd.org/D17573

Test Plan

Compiles fine on my machine. I've been unable to run test it.

http://joneumbox.org/build.html?mastername=112amd64-ports&build=2018-11-26_16h27m07s
http://joneumbox.org/build.html?mastername=112i386-ports&build=2018-11-26_16h27m07s

http://joneumbox.org/build.html?mastername=12amd64-ports&build=2018-11-26_16h30m40s
http://joneumbox.org/build.html?mastername=12i386-ports&build=2018-11-26_16h30m46s

http://joneumbox.org/build.html?mastername=13amd64-ports&build=2018-11-26_16h35m13s
http://joneumbox.org/build.html?mastername=13i386-ports&build=2018-11-26_16h35m32s

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20225
Build 19703: arc lint + arc unit

Event Timeline

madpilot created this revision.Oct 15 2018, 7:38 PM
Herald added a subscriber: mat. · View Herald TranscriptOct 15 2018, 7:38 PM
Harbormaster completed remote builds in B20225: Diff 49186.Oct 15 2018, 7:38 PM
madpilot added a reviewer: portmgr.Nov 23 2018, 2:59 PM

Adding portmgr, since I got no reply from the maintainer group.

mat added a comment.Nov 23 2018, 3:41 PM

What is the PR associated with this review that was used to notify the maintainer of the patch?

madpilot added a comment.Nov 23 2018, 3:46 PM
In D17573#388569, @mat wrote:

What is the PR associated with this review that was used to notify the maintainer of the patch?

I posted this directly here, actually.

mat added a comment.Nov 23 2018, 4:22 PM

Well, if you only posted it here and apache@ did not get notified because there is no PR trail, how can you claim timeout?

madpilot added a comment.Nov 23 2018, 4:32 PM
In D17573#388614, @mat wrote:

Well, if you only posted it here and apache@ did not get notified because there is no PR trail, how can you claim timeout?

My bad. I'll post a bug report.

madpilot edited the summary of this revision. (Show Details)Nov 23 2018, 4:40 PM
joneum edited the summary of this revision. (Show Details)Nov 26 2018, 3:49 PM
joneum edited the test plan for this revision. (Show Details)
joneum edited reviewers, added: ohauer, brnrd; removed: pgollucci, portmgr.
joneum added a subscriber: joneum.Nov 26 2018, 3:55 PM
brnrd accepted this revision.Nov 26 2018, 4:05 PM

LGTM

www/mod_rpaf2/Makefile
16

2.4+, 2.2 is long gone from the tree

This revision is now accepted and ready to land.Nov 26 2018, 4:05 PM
Closed by commit rP485946: www/mod_rpaf: The mod_rpaf configuration sample contains an error which makes… (authored by joneum). · Explain WhyNov 26 2018, 5:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
www/
mod_rpaf2/
10 lines
files/
2 lines

Diff 49186

View Options

www/mod_rpaf2/Makefile

Loading...
View Options

www/mod_rpaf2/files/200_mod_rpaf.conf.sample.in

Loading...