Page MenuHomeFreeBSD

www/h2o: add CONFLICTS and appease portlint
ClosedPublic

Authored by dch on Oct 8 2018, 9:52 AM.

Details

Summary

intentionally not bumping port version

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dch created this revision.Oct 8 2018, 9:52 AM
jrm added a subscriber: mat.Oct 9 2018, 5:31 PM

Looks good, but I think this will cause rumblings without a PORTREVISION bump. The policy I am familiar with is: If the package changes, then a PORTREVISION bump is necessary. Maybe if I mention the magic word, @mat, the port genie will appear to set us straight.

jrm added a comment.Oct 9 2018, 5:40 PM

I mentioned the policy, but it is probably more important to mention the underlying reason for the policy. I believe that without a PORTREVISION bump, a new package will not be built. With the USE_LDCONFIG= yes change, it seems we would want this, no?

dch added a comment.Oct 10 2018, 9:56 AM

If our policy gurus say it should be bumped, then I'm cool with that
but I don't see the need to inflict more unnecessary downloads and
upgrades on the planet than we already do.

FWIW these (from the -devel version) are what's in /usr/local/lib:

/usr/local/lib/libh2o-evloop.so
/usr/local/lib/libh2o-evloop.so.0.15
/usr/local/lib/libh2o-evloop.so.0.15.0-beta1
/usr/local/lib/libh2o.so
/usr/local/lib/libh2o.so.0.15
/usr/local/lib/libh2o.so.0.15.0-beta1

USE_LDCONFIG (at least with my meagre understanding of C & libraries)
is performing no additional function that isn't already in place, as
the port already works. So this USE_LDCONFIG isn't unbreaking anything
and isn't requiring users to update (what would they gain). Let's save
an erg of energy.

This revision is now accepted and ready to land.Oct 10 2018, 10:23 AM
This revision was automatically updated to reflect the committed changes.