Make domainset iterators unsigned.
ClosedPublic
Actions

Authored by markj on Oct 1 2018, 3:52 PM.

Tags

None

Referenced Files

	F167581784: D17374.id.diff
	Sat, Aug 22, 8:59 PM

	Unknown Object (File)
	Tue, Aug 18, 5:00 AM

	Unknown Object (File)
	Mon, Aug 17, 8:45 PM

	Unknown Object (File)
	Sun, Aug 16, 9:49 PM

	Unknown Object (File)
	Sat, Aug 15, 8:34 PM

	Unknown Object (File)
	Fri, Aug 14, 7:50 PM

	Unknown Object (File)
	Fri, Aug 14, 5:33 PM

	Unknown Object (File)
	Thu, Aug 13, 8:34 PM

View All Files

Subscribers

imp

Details

Reviewers

alc
jeff
kib

Commits

rS339075: Use an unsigned iterator for domain sets.

Summary

Otherwise iter % ds->ds_cnt will be negative once iter wraps around to a
negative number.

Test Plan

Peter found the problem while testing some other NUMA patches, one
of which adds a domainset iterator to each UMA keg.

It seems that the per-thread and per-object iterators never managed
to reach 0x80000000 in previous testing.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 1 2018, 3:52 PM

Harbormaster completed remote builds in B19894: Diff 48623.Oct 1 2018, 3:52 PM

markj edited the test plan for this revision. (Show Details)Oct 1 2018, 3:55 PM

markj added reviewers: alc, jeff, kib.

kib accepted this revision.Oct 1 2018, 4:04 PM

This revision is now accepted and ready to land.Oct 1 2018, 4:04 PM

Closed by commit rS339075: Use an unsigned iterator for domain sets. (authored by markj). · Explain WhyOct 1 2018, 6:51 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptOct 1 2018, 6:51 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

_domainset.h

2 lines

vm/

vm_domainset.h

2 lines

Diff 48631

View Options

head/sys/sys/_domainset.h