Page MenuHomeFreeBSD
Differential D17190

Rework if_ipsec(4) to use epoch(9)-based locking model.
ClosedPublic
Actions

Authored by ae on Sep 17 2018, 10:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 9:15 PM
Unknown Object (File)
Mon, Apr 29, 9:04 PM
Unknown Object (File)
Mon, Apr 29, 9:04 PM
Unknown Object (File)
Mon, Apr 29, 9:03 PM
Unknown Object (File)
Mon, Apr 29, 9:03 PM
Unknown Object (File)
Mon, Apr 29, 9:03 PM
Unknown Object (File)
Mon, Apr 29, 4:25 AM
Unknown Object (File)
Sun, Apr 28, 7:51 PM
View All 52 Files
Subscribers
imp

Details

Reviewers
None
Group Reviewers
network
Commits
rS339554: Rework if_ipsec(4) to use epoch(9) instead of rmlock.
Summary

Rework if_ipsec(4) to used epoch(9) instead of rmlock.

  • use CK_LIST and FNV hash to keep chains of softc;
  • read access to soft is protected by epoch();
  • write access is protected by ipsec_ioctl_sx. Change of softc fields allowed only when softc is unlinked from CK_LIST chains. And linking/unlinking is allowed only when ipsec_ioctl_sx is exclusive locked.
  • the plain LIST of all softc is replaced by hash table that uses ingress address of tunnels as key.
  • added support for appearing/disappearing of ingress address handling D17134. Now it is allowed configure non-local ingress IP address, and thus the problem with if_ipsec(4) configuration that happens on boot, when ingress address is not yet configured, is solved.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19616
Build 19192: arc lint + arc unit

Event Timeline

ae created this revision.Sep 17 2018, 10:38 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 17 2018, 10:38 AM
Harbormaster completed remote builds in B19616: Diff 48097.Sep 17 2018, 10:38 AM
ae updated this revision to Diff 48117.Sep 17 2018, 3:37 PM
ae edited the summary of this revision. (Show Details)

Deduplicate the code that deletes softc from srchash.
And add another IPSEC_WAIT() to fix possible race in ipsec_if_input().

Harbormaster completed remote builds in B19621: Diff 48117.Sep 17 2018, 3:37 PM
ae updated this revision to Diff 48118.Sep 17 2018, 3:41 PM

Upload the full diff.

Harbormaster completed remote builds in B19622: Diff 48118.Sep 17 2018, 3:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 21 2018, 6:24 PM
Closed by commit rS339554: Rework if_ipsec(4) to use epoch(9) instead of rmlock. (authored by ae). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
net/
377 lines

Diff 48097

View Options

sys/net/if_ipsec.c

Loading...