multimedia/xmms: add -znotext to LDFLAGS on i386, for lld
ClosedPublic
Actions

Authored by emaste on Sep 14 2018, 9:38 PM.

Details

Reviewers

tobik

Group Reviewers

Ports Committers

Summary

Example error:

/usr/bin/ld: error: can't create dynamic relocation R_386_32 against local symbol in readonly segment; recompile object files with -fPIC

This port links some non-PIC code, which fails with lld as it defaults to disallowing relocations against read-only segments. For i386 we can just add -znotext unconditionally: for GNU BFD ld it just affirms BFD's existing default.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Sep 14 2018, 9:38 PM

Could probably be written in a shorter way, like this:

LDFLAGS+=      ${LDFLAGS_${ARCH}}
LDFLAGS_i386=  -Wl,-znotext

multimedia/xmms/Makefile
27 ↗	(On Diff #48064)	missing blank line beteen `.include` and `.if`.

Update as suggested by @mat

multimedia/xmms/Makefile
26 ↗	(On Diff #48065)	Aside, is this the best choice, or bsd.port.pre.mk?

tobik requested changes to this revision.Sep 14 2018, 10:15 PM

tobik added a subscriber: tobik.

tobik added inline comments.

multimedia/xmms/Makefile
26 ↗	(On Diff #48065)	You should remove it. It is not needed now and it breaks the options that come after it. Options helpers that are set after including `bsd.port.pre.mk` or `bsd.port.options.mk` are not processed by the framework.