Differential D17155

graphics/partio: add DOXYGEN option
ClosedPublic
Actions

Authored by fernape on Sep 13 2018, 4:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 17, 7:49 AM

	Unknown Object (File)
	Sun, Oct 5, 4:46 AM

	Unknown Object (File)
	Sun, Sep 28, 3:17 AM

	Unknown Object (File)
	Sat, Sep 27, 9:18 AM

	Unknown Object (File)
	Fri, Sep 26, 11:25 PM

	Unknown Object (File)
	Sun, Sep 21, 5:05 AM

	Unknown Object (File)
	Sat, Sep 20, 2:43 PM

	Unknown Object (File)
	Sat, Sep 20, 5:20 AM

Subscribers

Details

Reviewers

tcberner
tz

Commits

rP480080: graphics/partio: Remove PYTHON option.

Summary

Most of the changes come from https://reviews.freebsd.org/D16662

Add DOXYGEN option.
Remove post-patch-PYTHON-off due to PYTHON_BROKEN_OFF
Move some variables to their proper locations

Test Plan

portlint -AC OK
poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fernape created this revision.Sep 13 2018, 4:21 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 13 2018, 4:21 PM

Harbormaster completed remote builds in B19571: Diff 48009.Sep 13 2018, 4:21 PM

mat added inline comments.Sep 14 2018, 10:10 AM

graphics/partio/Makefile
14 ↗	(On Diff #48009)	Why move this?
38 ↗	(On Diff #48009)	Why move this?

Keep USE_* sorted alphabetically

Harbormaster completed remote builds in B19596: Diff 48051.Sep 14 2018, 1:53 PM

Keep related variables close

Harbormaster completed remote builds in B19597: Diff 48052.Sep 14 2018, 1:54 PM

fernape marked 2 inline comments as done.Sep 14 2018, 1:55 PM

mat added inline comments.Sep 14 2018, 4:42 PM

graphics/partio/Makefile
15 ↗	(On Diff #48052)	Why blank line?
31 ↗	(On Diff #48052)	Remove this maybe.
33–36 ↗	(On Diff #48052)	Maybe remove the option if it is required now.

Remove blank line
Remove PYTHON option

Harbormaster completed remote builds in B19629: Diff 48133.Sep 17 2018, 5:04 PM

fernape marked 2 inline comments as done.Sep 17 2018, 5:05 PM

Looks good to me.

This revision is now accepted and ready to land.Sep 18 2018, 7:02 PM

Closed by commit rP480080: graphics/partio: Remove PYTHON option. (authored by fernape). · Explain WhySep 18 2018, 8:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

graphics/

partio/

27 lines

Diff 48185

head/graphics/partio/Makefile

Loading...