Page MenuHomeFreeBSD
Differential D17114

Update documentation for USES=gl
ClosedPublic
Actions

Authored by zeising on Sep 10 2018, 8:12 PM.
Tags
None
Referenced Files
F132423362: D17114.diff
Thu, Oct 16, 7:43 PM
Unknown Object (File)
Wed, Oct 15, 5:11 AM
Unknown Object (File)
Mon, Oct 13, 1:39 PM
Unknown Object (File)
Fri, Oct 10, 7:44 AM
Unknown Object (File)
Tue, Oct 7, 10:09 AM
Unknown Object (File)
Sun, Oct 5, 3:25 AM
Unknown Object (File)
Sat, Oct 4, 6:24 AM
Unknown Object (File)
Sat, Sep 20, 12:33 AM
View All Files
Subscribers
None

Details

Reviewers
mat
bcr
Commits
rD52257: Document USES=gl properly.
Summary

Update documentation for newly added USES=gl

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zeising created this revision.Sep 10 2018, 8:12 PM
Herald added a reviewer: mat. · View Herald TranscriptSep 10 2018, 8:12 PM
Harbormaster completed remote builds in B19508: Diff 47894.Sep 10 2018, 8:12 PM
zeising updated this revision to Diff 47895.Sep 10 2018, 8:12 PM
zeising set the repository for this revision to rD FreeBSD doc repository - subversion.
zeising added a reviewer: bcr.
zeising added a subscriber: bcr.
zeising removed a subscriber: bcr.
mat added a comment.Sep 10 2018, 8:31 PM

Could there be some description of each component?

zeising updated this revision to Diff 47923.Sep 11 2018, 6:54 PM

Update diff with a more verbose explanation.

Harbormaster completed remote builds in B19528: Diff 47923.Sep 11 2018, 6:54 PM
bcr added a comment.Sep 11 2018, 6:57 PM

Two nits that I found, the rest is fine from the doc side (can't say much about the actual content).

en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
704 ↗(On Diff #47923)

s/depenency/dependency/

716 ↗(On Diff #47923)

No </para> here.

zeising updated this revision to Diff 47924.Sep 11 2018, 7:02 PM

Fix spelling, remove some <para> that were in the wrong place, and add some missing words.

Now where did i put my coffee cup?

Harbormaster completed remote builds in B19529: Diff 47924.Sep 11 2018, 7:02 PM
zeising marked 2 inline comments as done.Sep 11 2018, 7:02 PM
bcr accepted this revision.Sep 11 2018, 7:25 PM

OK from the docs side.

mat added a comment.Sep 11 2018, 7:34 PM

This should probably be using a variablelist instead of a itemizedlist, see Example 9.12. variablelist Example.

zeising updated this revision to Diff 47942.Sep 12 2018, 5:59 AM

Update to use variablelist instead.

Harbormaster completed remote builds in B19535: Diff 47942.Sep 12 2018, 5:59 AM
mat accepted this revision.Sep 12 2018, 8:09 AM
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
704 ↗(On Diff #47942)

The literals in all the terms should still be in <literal> tags.

This revision is now accepted and ready to land.Sep 12 2018, 8:09 AM
zeising updated this revision to Diff 47956.Sep 12 2018, 4:22 PM

Add literals

This revision now requires review to proceed.Sep 12 2018, 4:22 PM
Harbormaster completed remote builds in B19545: Diff 47956.Sep 12 2018, 4:22 PM
zeising marked an inline comment as done.Sep 12 2018, 4:22 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 14 2018, 7:04 PM
Closed by commit rD52257: Document USES=gl properly. (authored by zeising). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
books/
porters-handbook/
uses/
85 lines

Diff 48062

View Options

head/en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml

Loading...