Page MenuHomeFreeBSD
Differential D17060

net/packetdrill: fix distinfo
ClosedPublic
Actions

Authored by kbowling on Sep 6 2018, 8:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 7, 8:37 PM
Unknown Object (File)
Thu, Nov 27, 4:35 AM
Unknown Object (File)
Fri, Nov 21, 6:38 AM
Unknown Object (File)
Fri, Nov 21, 6:38 AM
Unknown Object (File)
Fri, Nov 21, 6:37 AM
Unknown Object (File)
Fri, Nov 21, 6:32 AM
Unknown Object (File)
Tue, Nov 18, 10:38 AM
Unknown Object (File)
Nov 7 2025, 9:18 PM
View All 74 Files
Subscribers
mat

Details

Reviewers
krion
timur
Commits
rP479109: net/packetdrill: fix forgotten distinfo update in rP478992
Summary

Accidentally inconsistent with PORTVERSION name

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kbowling created this revision.Sep 6 2018, 8:56 AM
Herald added a subscriber: mat. · View Herald TranscriptSep 6 2018, 8:56 AM
kbowling retitled this revision from net/packetdrill: fix distino to net/packetdrill: fix distinfo.Sep 6 2018, 8:56 AM
krion added a comment.Sep 6 2018, 2:44 PM

Hmm, there's no need for this change. As if content of distfile remains the same and checksum/size are the same, no changes are necessary.

timur added a comment.EditedSep 6 2018, 2:47 PM

That's not working OOTB.

===>   packetdrill-0.0.2018081901 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by packetdrill-0.0.2018081901 for building
===>  Extracting for packetdrill-0.0.2018081901
=> No SHA256 checksum recorded for freebsd-net-packetdrill-0.0.2018081901-d449b32_GH0.tar.gz.
=> No suitable checksum found for freebsd-net-packetdrill-0.0.2018081901-d449b32_GH0.tar.gz.
*** Error code 1

My fault, had to check closer. Kevin, please use make makesum next time to get consistent distinfo.

timur accepted this revision.Sep 6 2018, 5:19 PM

Approved

This revision is now accepted and ready to land.Sep 6 2018, 5:19 PM
krion accepted this revision.Sep 6 2018, 5:28 PM

Please write appropriate log message to commit it, to not confuse people, smth like:

Fix to commit forgotten distfile by previous commit.

Closed by commit rP479109: net/packetdrill: fix forgotten distinfo update in rP478992 (authored by kbowling). · Explain WhySep 6 2018, 5:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
6 lines

Diff 47722

View Options

distinfo

Loading...