Page MenuHomeFreeBSD

devel/flang[-clang]: update to later revision
ClosedPublic

Authored by jmd on Sep 5 2018, 2:07 AM.

Details

Summary

Update devel/flang and devel/flang-clang to a later revision. This introduces flang-driver, a clang6-derived driver, and uses math/libpgmath. Notably, the latter currently limits us to 12-CURRENT.

Patches are a combination of carry-over and adapted OpenBSD ones.

While there, pet portlint.

Test Plan

poudriere tested on 12 amd64. compiles trivial test codes correctly. portlint clean now.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jmd created this revision.Sep 5 2018, 2:07 AM
mat added a comment.Sep 5 2018, 3:18 PM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

devel/flang-clang/Makefile
21 ↗(On Diff #47679)

This message will never be used. Would probably better to be removed.

devel/flang/Makefile
15 ↗(On Diff #47679)

This will never be used, and it would probably better be removed, it is close to the automatically generated message.

jmd marked an inline comment as done.Sep 5 2018, 7:06 PM

Done

jmd updated this revision to Diff 47707.Sep 5 2018, 7:07 PM

Addressed comments

mat added inline comments.Sep 6 2018, 12:46 PM
devel/flang-clang/Makefile
21 ↗(On Diff #47707)

This variable will never be used. Also, its message is the default one.

23 ↗(On Diff #47707)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

27 ↗(On Diff #47707)

Why +=?

devel/flang/Makefile
45–48 ↗(On Diff #47707)
TESTS_CMAKE_ON= FLAGN_INCLUDE_TEST
jmd updated this revision to Diff 47750.Sep 6 2018, 1:49 PM

Address next rounds of comments.

jmd marked 5 inline comments as done.Sep 6 2018, 1:49 PM

Address comments for existing parts of the ports.

zeising accepted this revision.Sep 6 2018, 7:39 PM

Looks good to me. Approved.

This revision is now accepted and ready to land.Sep 6 2018, 7:39 PM
This revision was automatically updated to reflect the committed changes.