Page MenuHomeFreeBSD

Porters Handbook: Remove shar file instructions
AbandonedPublic

Authored by ndowens_yahoo.com on Aug 25 2018, 6:17 AM.

Details

Reviewers
mat
Summary
  • Removal of shar instructions
    • We are at the state of shar/diff, while diff is preferred, as it makes it easier for developers/commiters to use
    • Been encouraging the use of diffs over shar, in which this is the next step

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19170
Build 18790: arc lint + arc unit

Event Timeline

I disagree with this change. We support submitting new ports using shar, so it needs to be documented.

In D16896#360150, @mat wrote:

I disagree with this change. We support submitting new ports using shar, so it needs to be documented.

I can see both sides :) though, when trying to review the patch, when it is a shar file, in bugzilla; can't just look at them. Have to download then use an editor to look at it. Also, could be considered a possible "security" issue. If someone new to UNIX-like systems was running as root and didn't checkout what the shar file contained; they could execute it and it cause malicious activity.

linimon retitled this revision from Remove shar file instructions to Porters Handbook: Remove shar file instructions.Aug 27 2018, 9:42 AM

We have Tools/scripts/sunshar.rb to safely unpack shar archives.

Also, doing everything as root is a bad idea. The only thing you need to run as root when testing ports is poudriere testport. Everything else can, and should, be done as a regular user.