- Removal of shar instructions
- We are at the state of shar/diff, while diff is preferred, as it makes it easier for developers/commiters to use
- Been encouraging the use of diffs over shar, in which this is the next step
I can see both sides :) though, when trying to review the patch, when it is a shar file, in bugzilla; can't just look at them. Have to download then use an editor to look at it. Also, could be considered a possible "security" issue. If someone new to UNIX-like systems was running as root and didn't checkout what the shar file contained; they could execute it and it cause malicious activity.
We have Tools/scripts/sunshar.rb to safely unpack shar archives.
Also, doing everything as root is a bad idea. The only thing you need to run as root when testing ports is poudriere testport. Everything else can, and should, be done as a regular user.