Page MenuHomeFreeBSD
Differential D16892

add pci support at rt1310
AbandonedPublic
Actions

Authored by yamori813_yahoo.co.jp on Aug 24 2018, 10:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 25, 7:22 PM
Unknown Object (File)
Sun, Nov 23, 11:50 AM
Unknown Object (File)
Sat, Nov 22, 6:03 PM
Unknown Object (File)
Wed, Nov 19, 4:29 AM
Unknown Object (File)
Wed, Nov 12, 11:00 PM
Unknown Object (File)
Oct 27 2025, 4:55 AM
Unknown Object (File)
Oct 19 2025, 9:56 AM
Unknown Object (File)
Oct 15 2025, 11:20 AM
View All 69 Files
Subscribers
andrew

Details

Reviewers
imp
adrian
mizhka
manu
Test Plan

WZR2-G300N

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19160
Build 18783: arc lint + arc unit

Event Timeline

yamori813_yahoo.co.jp created this revision.Aug 24 2018, 10:27 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 24 2018, 10:27 PM
Harbormaster completed remote builds in B19160: Diff 47269.Aug 24 2018, 10:27 PM
manu removed a reviewer: manu.Mar 21 2019, 7:31 AM
Herald added a reviewer: manu. · View Herald TranscriptMar 21 2019, 7:31 AM
Herald added a subscriber: andrew. · View Herald Transcript
manu added a comment.Mar 21 2019, 7:31 AM

Remove myself from blocking reviewer.

manu removed a reviewer: manu.Mar 21 2019, 7:31 AM
Herald added a reviewer: manu. · View Herald TranscriptMar 21 2019, 7:31 AM
manu added a comment.Mar 21 2019, 7:32 AM

Herald doesn't like this ...
Consider it ok from me for dts changes.

mizhka added a comment.Mar 21 2019, 7:52 AM

Generally looks good. Please fix easy remarks.

sys/arm/ralink/rt1310_machdep.c
107

Why so big window? May be better to add additional entry?

sys/arm/ralink/rt1310_pci.c
256

Please move to beginning of function

274

Please split to 2 lines: declaration and assignment.

andrew added inline comments.Mar 21 2019, 10:20 AM
sys/arm/ralink/rt1310_machdep.c
127

This should be in a common header.

sys/arm/ralink/rt1310_pci.c
35

Is this needed?

237

What is this delay for?

239–243

What are these magic numbers?

244

And this delay. It's also held while we hold a mutex.

249–254

More magic numbers.

yamori813_yahoo.co.jp abandoned this revision.Feb 2 2020, 12:46 PM

Revision Contents
Changeset List

PathSize
sys/
arm/
ralink/
1 line
19 lines
573 lines
dts/
arm/
21 lines

Diff 47269

View Options

sys/arm/ralink/files.ralink

Loading...
View Options

sys/arm/ralink/rt1310_machdep.c

Loading...
View Options

sys/arm/ralink/rt1310_pci.c

Loading...
View Options

sys/dts/arm/rt1310a.dtsi

Loading...