Page MenuHomeFreeBSD

add pci support at rt1310
Needs ReviewPublic

Authored by yamori813_yahoo.co.jp on Aug 24 2018, 10:27 PM.

Details

Test Plan

WZR2-G300N

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 19160
Build 18783: arc lint + arc unit

Event Timeline

manu removed a reviewer: manu.Mar 21 2019, 7:31 AM
manu added a comment.Mar 21 2019, 7:31 AM

Remove myself from blocking reviewer.

manu removed a reviewer: manu.Mar 21 2019, 7:31 AM
manu added a comment.Mar 21 2019, 7:32 AM

Herald doesn't like this ...
Consider it ok from me for dts changes.

Generally looks good. Please fix easy remarks.

sys/arm/ralink/rt1310_machdep.c
107

Why so big window? May be better to add additional entry?

sys/arm/ralink/rt1310_pci.c
256

Please move to beginning of function

274

Please split to 2 lines: declaration and assignment.

andrew added inline comments.Mar 21 2019, 10:20 AM
sys/arm/ralink/rt1310_machdep.c
127

This should be in a common header.

sys/arm/ralink/rt1310_pci.c
35

Is this needed?

237

What is this delay for?

239–243

What are these magic numbers?

244

And this delay. It's also held while we hold a mutex.

249–254

More magic numbers.