Page MenuHomeFreeBSD

add pci support at rt1310
AbandonedPublic

Authored by yamori813_yahoo.co.jp on Aug 24 2018, 10:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 3, 5:48 PM
Unknown Object (File)
Mon, Mar 2, 5:36 PM
Unknown Object (File)
Mon, Mar 2, 2:40 AM
Unknown Object (File)
Sat, Feb 21, 4:19 AM
Unknown Object (File)
Feb 3 2026, 2:28 AM
Unknown Object (File)
Nov 25 2025, 7:22 PM
Unknown Object (File)
Nov 23 2025, 11:50 AM
Unknown Object (File)
Nov 22 2025, 6:03 PM
Subscribers

Details

Test Plan

WZR2-G300N

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19160
Build 18783: arc lint + arc unit

Event Timeline

Remove myself from blocking reviewer.

Herald doesn't like this ...
Consider it ok from me for dts changes.

Generally looks good. Please fix easy remarks.

sys/arm/ralink/rt1310_machdep.c
107

Why so big window? May be better to add additional entry?

sys/arm/ralink/rt1310_pci.c
256

Please move to beginning of function

274

Please split to 2 lines: declaration and assignment.

sys/arm/ralink/rt1310_machdep.c
127

This should be in a common header.

sys/arm/ralink/rt1310_pci.c
35

Is this needed?

237

What is this delay for?

239–243

What are these magic numbers?

244

And this delay. It's also held while we hold a mutex.

249–254

More magic numbers.