Fix vfs_busy leaks in ufs_quotactl
ClosedPublic
Actions

Authored by cse_cem_gmail_com on Jan 27 2015, 12:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 10, 10:20 PM

	Unknown Object (File)
	Fri, Oct 10, 10:20 PM

	Unknown Object (File)
	Fri, Oct 10, 4:20 PM

	Unknown Object (File)
	Tue, Sep 30, 10:24 PM

	Unknown Object (File)
	Mon, Sep 29, 5:18 PM

	Unknown Object (File)
	Aug 31 2025, 4:26 PM

	Unknown Object (File)
	Aug 28 2025, 9:41 PM

	Unknown Object (File)
	Aug 18 2025, 8:52 PM

View All Files

Subscribers

kib

Details

Reviewers

kib
emaste
pho
mckusick

Summary

The sys_quotactl contract demands that the mp is vfs_unbusy()ed when the
cmd is Q_QUOTAON, regardless of other input parameters or error return.

Sponsored by: EMC / Isilon Storage Division

Test Plan

pho's quota9.sh test from stress2 easily and quickly reproduces this issue and confirms the fix:

http://svn.freebsd.org/base/user/pho/stress2/misc/quota9.sh

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

cse_cem_gmail_com updated this revision to Diff 3450.Jan 27 2015, 12:17 AM

cse_cem_gmail_com retitled this revision from to Fix vfs_busy leaks in ufs_quotactl.

cse_cem_gmail_com updated this object.

cse_cem_gmail_com edited the test plan for this revision. (Show Details)

cse_cem_gmail_com added reviewers: pho, emaste.

cse_cem_gmail_com added a reviewer: mckusick.Jan 27 2015, 12:20 AM

emaste added a subscriber: kib.Jan 27 2015, 1:26 AM

Yes, the fix looks correct.

This revision is now accepted and ready to land.Jan 27 2015, 9:17 AM

Problem verified http://people.freebsd.org/~pho/stress/log/quota9.txt.
Patch tested OK on GENERIC and non QUOTA build.

r277794

Thanks!

Revision Contents
Changeset List

Path

Size

sys/

ufs/

ufs_quota.c

8 lines

ufs_vfsops.c

10 lines

Diff 3450

View Options

sys/ufs/ufs/ufs_quota.c