Page MenuHomeFreeBSD

Fix vfs_busy leaks in ufs_quotactl
ClosedPublic

Authored by cse_cem_gmail_com on Jan 27 2015, 12:17 AM.

Details

Summary

The sys_quotactl contract demands that the mp is vfs_unbusy()ed when the
cmd is Q_QUOTAON, regardless of other input parameters or error return.

Sponsored by: EMC / Isilon Storage Division

Test Plan

pho's quota9.sh test from stress2 easily and quickly reproduces this issue and confirms the fix:

http://svn.freebsd.org/base/user/pho/stress2/misc/quota9.sh

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

cse_cem_gmail_com retitled this revision from to Fix vfs_busy leaks in ufs_quotactl.
cse_cem_gmail_com updated this object.
cse_cem_gmail_com edited the test plan for this revision. (Show Details)
cse_cem_gmail_com added reviewers: pho, emaste.
kib added a reviewer: kib.

Yes, the fix looks correct.

This revision is now accepted and ready to land.Jan 27 2015, 9:17 AM

Problem verified http://people.freebsd.org/~pho/stress/log/quota9.txt.
Patch tested OK on GENERIC and non QUOTA build.