Page MenuHomeFreeBSD
Differential D16708

Move all shell related files to bin/sh/ and bin/csh/
ClosedPublic
Actions

Authored by brd on Aug 14 2018, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 4, 7:01 PM
Unknown Object (File)
Tue, Nov 4, 4:21 PM
Unknown Object (File)
Tue, Nov 4, 4:19 PM
Unknown Object (File)
Tue, Nov 4, 4:19 PM
Unknown Object (File)
Tue, Nov 4, 1:53 PM
Unknown Object (File)
Fri, Oct 31, 9:43 PM
Unknown Object (File)
Fri, Oct 31, 11:37 AM
Unknown Object (File)
Thu, Oct 30, 3:27 PM
View All Files
Subscribers
imp

Details

Reviewers
will
allanjude
jilles
Commits
rS337849: Move all sh and csh files into bin/sh/ or bin/csh/
Test Plan

Compare the results from make distribution

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brd created this revision.Aug 14 2018, 2:14 PM
Herald added a reviewer: jilles. · View Herald TranscriptAug 14 2018, 2:14 PM
Herald added a subscriber: imp. · View Herald Transcript
Harbormaster completed remote builds in B18787: Diff 46659.Aug 14 2018, 2:14 PM
will requested changes to this revision.Aug 14 2018, 8:57 PM

Issues using LINKS, on cursory inspection.

bin/csh/Makefile
53 ↗(On Diff #46659)

bsd.links.mk prepends ${DESTDIR} to both source and target.

bin/sh/Makefile
40 ↗(On Diff #46659)

See above.

68 ↗(On Diff #46659)

Why is this appropriate for this particular file?

This revision now requires changes to proceed.Aug 14 2018, 8:57 PM
brd updated this revision to Diff 46696.Aug 15 2018, 10:46 AM
brd marked 2 inline comments as done.

Update to remove DESTDIR from LINKS

Harbormaster completed remote builds in B18805: Diff 46696.Aug 15 2018, 10:47 AM
brd added inline comments.Aug 15 2018, 10:48 AM
bin/sh/Makefile
68 ↗(On Diff #46659)

That is what we do today in etc/Makefile.. but it has been there for almost 10 years, so perhaps it is time for it to go.

will accepted this revision.Aug 15 2018, 2:10 PM
This revision is now accepted and ready to land.Aug 15 2018, 2:10 PM
Closed by commit rS337849: Move all sh and csh files into bin/sh/ or bin/csh/ (authored by brd). · Explain WhyAug 15 2018, 2:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
bin/
csh/
15 lines
3 lines
15 lines
3 lines
43 lines
12 lines
sh/
7 lines
16 lines
18 lines
etc/
24 lines
3 lines
15 lines
3 lines
18 lines
root/
43 lines
12 lines
16 lines

Diff 46707

View Options

head/bin/csh/Makefile

Loading...
View Options

head/bin/csh/csh.cshrc

Loading...
View Options

head/bin/csh/csh.login

Loading...
View Options

head/bin/csh/csh.logout

Loading...
View Options

head/bin/csh/dot.cshrc

Loading...
View Options

head/bin/csh/dot.login

Loading...
View Options

head/bin/sh/Makefile

Loading...
View Options

head/bin/sh/dot.profile

Loading...
View Options

head/bin/sh/profile

Loading...
View Options

head/etc/Makefile

Loading...
View Options

head/etc/csh.cshrc

Loading...
View Options

head/etc/csh.login

Loading...
View Options

head/etc/csh.logout

Loading...
View Options

head/etc/profile

Loading...
View Options

head/etc/root/dot.cshrc

Loading...
View Options

head/etc/root/dot.login

Loading...
View Options

head/etc/root/dot.profile

Loading...